1724212 - Localized address bar chiclet is not entirely visible with some locales

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Petruta Horea [:phorea], Desktop QA]

Attachment: address bar chiclet localizations / Figma

Affected versions

• Nightly 92.0a1 2021-08-04

Affected platforms

• Windows 10 64-bit
• Ubuntu 18.04 64-bit

Steps to reproduce

1. Download a Firefox localized build (eg: ta, pl)
2. Open a certificate error page (eg: https://wrong.host.badssl.com/)
3. Check the address bar chiclet
4. Narrow browser width to min and verify the address bar chiclet
5. Check if a tooltip is available when the chiclet is not entirely visible

Expected result

• As described in Figma, the chiclet text should always be visible, no matter the window size

Actual result

• Longer strings are replaced by ellipses even on normal screens
• On narrow windows, text can be totally replaced by ellipses
• There is no tooltip for address bar chiclet

Regression range

• Not a regression

Comment 1

[:Gijs (he/him)]

Looks like this rule is wide enough on macOS but not on Windows/Linux; on Win10, increasing from 10 to 13em is enough.

Still, adding a tooltip would also be useful, I think.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1724212 - add a tooltip and show more of the 'not secure' item so languages other than English fit, r?johannh,pbz

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d8ffaf9addd
add a tooltip and show more of the 'not secure' item so languages other than English fit, r=pbz

Comment 4

[:Gijs (he/him)]

Comment on attachment 9236629 [details]
Bug 1724212 - add a tooltip and show more of the 'not secure' item so languages other than English fit, r?johannh,pbz

Beta/Release Uplift Approval Request

• User impact if declined: On some locales the "not secure" text is unreadable
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: no
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS change + adding an existing tooltip that wasn't being applied correctly with a 1 line patch.
• String changes made/needed: No - we're using an existing string

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7d8ffaf9addd

Comment 6

[Timea Cernea [:tbabos][inactive]]

Verified the fix on the latest Nightly 93.0a1 on Windows 7/10 and Ubuntu 20.04, 18.04.

The following items are verified-fixed:

• Longer strings are replaced by ellipses even on normal screens
• There is no tooltip for address bar chiclet

Not fixed:

• Ubuntu specific bug: On narrow windows, text can be totally replaced by ellipses. However, this is reproducible with a very edge case window width and height, as can be seen in the attached screenshot.

Hey Gijs, I am considering marking this as verified-fixed as it is and follow-up with a new issue for Ubuntu if you consider it relevant, given the uncommon scenario. Let me know how it should go, thanks!

Comment 7

[Timea Cernea [:tbabos][inactive]]

Attachment: Ubuntu issue - after Nightly fix

Comment 8

[:Gijs (he/him)]

(In reply to Timea Cernea [:tbabos] from comment #6)

Not fixed:

• Ubuntu specific bug: On narrow windows, text can be totally replaced by ellipses. However, this is reproducible with a very edge case window width and height, as can be seen in the attached screenshot.

Hey Gijs, I am considering marking this as verified-fixed as it is and follow-up with a new issue for Ubuntu if you consider it relevant, given the uncommon scenario. Let me know how it should go, thanks!

Yeah, let's get it on file at least.

Comment 9

[Timea Cernea [:tbabos][inactive]]

Thanks Gijs, submitted Bug 1726511 to cover the Unbuntu case. Marking nightly as verified-fixed based on Comment 6 and waiting for potential Uplift to Beta for further verification.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9236629 [details]
Bug 1724212 - add a tooltip and show more of the 'not secure' item so languages other than English fit, r?johannh,pbz

Approved for 92.0b6.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fa48d725250e

Comment 12

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on the latest Firefox Beta 92.0b8 (64-bit) on Windows 10 and Windows 7.