1724227 - [wdspec] Only reset the current BiDi session if capabilities have been changed

Status: RESOLVED FIXED

(Testing :: geckodriver, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Right now the WebDriver session for BiDi tests is reset after each and every test. I assume that reset_current_session_if_necessary doesn't take into account that for the requested capabilities the webSocketURL is not set, or is True while the current capabilities have the actual URL set:

https://searchfox.org/mozilla-central/rev/00977c4e37865a92f1c15572ae4aea90e934b25b/testing/web-platform/tests/webdriver/tests/support/fixtures.py#125-137

This might become a P3 for our milestone 1. Lets discuss next week.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1724227 - [wdspec] Determine re-creation of session or bidi session based on capabilities.

Depends on D122336

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3bfdc6c788d
[wdspec] Determine re-creation of session or bidi session based on capabilities. r=webdriver-reviewers,jgraham,jdescottes

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29997 for changes under testing/web-platform/tests

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out 5 changesets (bug 1694144, bug 1724227) for causing bc failures in browser_all_files_referenced.js.
https://hg.mozilla.org/integration/autoland/rev/17857f4eb7cee954fd2a56876596ed96ff076c87

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

That's a problem with the other bug. Here all is still fine.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df06ea473574
[wdspec] Determine re-creation of session or bidi session based on capabilities. r=webdriver-reviewers,jgraham,jdescottes

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/df06ea473574

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham