Closed Bug 1724227 Opened 4 years ago Closed 4 years ago

[wdspec] Only reset the current BiDi session if capabilities have been changed

Categories

(Testing :: geckodriver, defect, P2)

Product:
Testing
Component:
geckodriver
Version:
Default
Type:
defect
Points:
2

Tracking

(firefox93 fixed)

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [bidi-m1-mvp], [wptsync upstream])

Attachments

(1 file)

Bug 1724227 - [wdspec] Determine re-creation of session or bidi session based on capabilities.
48 bytes, text/x-phabricator-request
Details | Review

Right now the WebDriver session for BiDi tests is reset after each and every test. I assume that reset_current_session_if_necessary doesn't take into account that for the requested capabilities the webSocketURL is not set, or is True while the current capabilities have the actual URL set:

https://searchfox.org/mozilla-central/rev/00977c4e37865a92f1c15572ae4aea90e934b25b/testing/web-platform/tests/webdriver/tests/support/fixtures.py#125-137

This might become a P3 for our milestone 1. Lets discuss next week.

Points: --- → 2
Whiteboard: [webdriver:triage] → [bidi-m1-mvp]
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Blocks: 1694144
Priority: P3 → P2
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3bfdc6c788d [wdspec] Determine re-creation of session or bidi session based on capabilities. r=webdriver-reviewers,jgraham,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29997 for changes under testing/web-platform/tests
Whiteboard: [bidi-m1-mvp] → [bidi-m1-mvp], [wptsync upstream]

Backed out 5 changesets (bug 1694144, bug 1724227) for causing bc failures in browser_all_files_referenced.js.
https://hg.mozilla.org/integration/autoland/rev/17857f4eb7cee954fd2a56876596ed96ff076c87

That's a problem with the other bug. Here all is still fine.

Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/df06ea473574 [wdspec] Determine re-creation of session or bidi session based on capabilities. r=webdriver-reviewers,jgraham,jdescottes

https://hg.mozilla.org/mozilla-central/rev/df06ea473574

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: