Closed
Bug 1724227
Opened 3 years ago
Closed 3 years ago
[wdspec] Only reset the current BiDi session if capabilities have been changed
Categories
(Testing :: geckodriver, defect, P2)
Tracking
(firefox93 fixed)
RESOLVED
FIXED
93 Branch
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [bidi-m1-mvp], [wptsync upstream])
Attachments
(1 file)
Right now the WebDriver session for BiDi tests is reset after each and every test. I assume that reset_current_session_if_necessary doesn't take into account that for the requested capabilities the webSocketURL is not set, or is True while the current capabilities have the actual URL set:
This might become a P3 for our milestone 1. Lets discuss next week.
|
||
Updated•3 years ago
|
Points: --- → 2
Whiteboard: [webdriver:triage] → [bidi-m1-mvp]
|
Assignee | |
Comment 1•3 years ago
|
||
Depends on D122336
|
||
Updated•3 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3bfdc6c788d [wdspec] Determine re-creation of session or bidi session based on capabilities. r=webdriver-reviewers,jgraham,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29997 for changes under testing/web-platform/tests
Whiteboard: [bidi-m1-mvp] → [bidi-m1-mvp], [wptsync upstream]
|
||
Comment 4•3 years ago
|
||
Backed out 5 changesets (bug 1694144, bug 1724227) for causing bc failures in browser_all_files_referenced.js.
https://hg.mozilla.org/integration/autoland/rev/17857f4eb7cee954fd2a56876596ed96ff076c87
|
|
Assignee | |
Comment 5•3 years ago
|
||
That's a problem with the other bug. Here all is still fine.
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/df06ea473574 [wdspec] Determine re-creation of session or bidi session based on capabilities. r=webdriver-reviewers,jgraham,jdescottes
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox93:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
Upstream PR merged by jgraham
You need to log in
before you can comment on or make changes to this bug.
Description
•