1724249 - Don't add interactions if they are part of the adult filter list

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, task, P2)

Description

[Mark Banner (:standard8)]

New tab page already has an adult filter list, we want to filter out adult sites from being recorded in interactions as well.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1724249 - Don't add interactions if they are part of the adult filter list. r?amy!

Comment 2

[Amy Churchwell [:amy]]

Testing instructions from slack:

Enter the following into any browser console to get a hash for the website of your choice, then add that to the list:

c = Cc["@mozilla.org/security/hash;1"].createInstance(Ci.nsICryptoHash);
text = "mozilla.org"; c.init(c.MD5); c.update(text.split("").map(c => c.charCodeAt(0)), text.length ); c.finish(true);

Once you’ve done that, on your test build profile, add these prefs as Booleans with value true:

• browser.places.interactions.enabled
• browser.places.interactions.log

Then restart.

If you now visit the website, you should see logging on the browser console that says interactions for that website were blocked.

You can further check this by visiting chrome://browser/content/places/interactionsViewer.html and selecting “Interactions”, where they shouldn’t be showing up for recent visits (if you visited the site previously, it might still show up, of course).

I think there’s a 10 second write timer on end of interactions and there’s a 10 second timer on a page, so interactions can take a while to show up.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/300b61c0c82b
Don't add interactions if they are part of the adult filter list. r=amy

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/300b61c0c82b