Closed Bug 1724290 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29920 - [WebCodecs] Improve errors when operating on closed VideoFrame.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox93 fixed)

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29920 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29920
Details from upstream follow.

b'Dale Curtis <dalecurtis@chromium.org>' wrote:

[WebCodecs] Improve errors when operating on closed VideoFrame.

This adds exceptions when texturing or drawing a closed VideoFrame
to canvas via WebGL or 2D canvas respectively. These are clear
programming errors that should be called out and not operational
errors that might occur in the wild.

It's unclear if this is the problem of the linked issue, but it
will certainly help users track down issues if so.

Bug: 1236821
Change-Id: I590aa020b74483b58602e5237582889bc5e3cd3e

Reviewed-on: https://chromium-review.googlesource.com/3075927
WPT-Export-Revision: 23808ec5617f0a35ac78eba4cb981d2489899361

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 6 subtests

Status Summary

Firefox

OK : 4
FAIL: 24

Chrome

OK : 4
PASS: 24

Safari

OK : 4
FAIL: 24

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/videoFrame-drawImage.any.html
drawImage(VideoFrame) with canvas(48x36 srgb uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(480x360 srgb uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(48x36 display-p3 uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(480x360 display-p3 uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(48x36 rec2020 uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage on a closed VideoFrame throws InvalidStateError.: FAIL (Chrome: PASS, Safari: FAIL)
/webcodecs/videoFrame-drawImage.any.worker.html
drawImage(VideoFrame) with canvas(48x36 srgb uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(480x360 srgb uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(48x36 display-p3 uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(480x360 display-p3 uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage(VideoFrame) with canvas(48x36 rec2020 uint8).: FAIL (Chrome: PASS, Safari: FAIL)
drawImage on a closed VideoFrame throws InvalidStateError.: FAIL (Chrome: PASS, Safari: FAIL)
/webcodecs/videoFrame-texImage.any.html
texImage2D with 48x36 srgb VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
texSubImage2D with 48x36 srgb VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
texImage2D with 480x360 srgb VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
texSubImage2D with 480x360 srgb VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
texImage2D with a closed VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
texSubImage2D with a closed VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
/webcodecs/videoFrame-texImage.any.worker.html
texImage2D with 48x36 srgb VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
texSubImage2D with 48x36 srgb VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
texImage2D with 480x360 srgb VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
texSubImage2D with 480x360 srgb VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
texImage2D with a closed VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)
texSubImage2D with a closed VideoFrame.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ed81480ae53
[wpt PR 29920] - [WebCodecs] Improve errors when operating on closed VideoFrame., a=testonly
https://hg.mozilla.org/integration/autoland/rev/82e28aa16eae
[wpt PR 29920] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8ed81480ae53
https://hg.mozilla.org/mozilla-central/rev/82e28aa16eae

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.