1724593 - Update to v90.0.2 deleted my sessionstore-backups

Status: RESOLVED INCOMPLETE

(Firefox :: Session Restore, defect)

Description

[Suhfgh]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

Upgrade version to 90.0.2

Actual results:

I lost all my sessionstore-backups. I lost all my tabs that I had open and also sessionstore-backups directory in my profile was empty. Not even previous versions of files were there.
Later I teted it multiple times, both by closing browser window from X and also by killing ff from task manager. In both cases sessionstore-backups stayed there so it could not be configuration issue.

Expected results:

sessionstore-backups should have stayed untouched.

to fix this I would like to suggest a new modification to firefox: Never delete anything directly. Instead create .trash directory in FF profile and then refactor delete operations everywhere in browser to move files in .trash instead. And then make the clean-up process such that when browser starts up it would delete files from .trash directory that are older than some user configured parameter. For example default could be 24h but about:config could override it.

This could avoid accidents because in my case I noticed it immediately and I could have recovered them from .trash folder.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Session Restore' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Jeronimo Torti (Please send NI request to Brindusa Tot)]

Hi Suhfgh
I have tried to reproduce the issue on Windows 10, on Firefox Nightly 93.0a1 (2021-08-23) (64-bit) version and Release (upgrading from 90.0.1 to) 91.0.1 (64-bit) versions, but I was unable to reproduce it. Upgrading the versions did not make to lose sessionstore-backups.

Could you answer the following questions in order to further investigate this issue?

1. Does this issue happen with a new profile? Here is a link on how to create a new profile: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles

Can you test the issue while in Safe Mode. You can find helpful info here : https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode.

2. Does this issue occur in the latest nightly version of firefox? Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/

3. How many tabs did you have opened? In which specific pages did you experience the issue? Can you reproduce the issue while 'Restore previous session' option was checked on 'about:preferences'?

If you are still able to reproduce it, please, share further information with us, like screen recording, or more specific steps.

I let the already selected component in order to get the dev team involved.
Firefox-Session Restore' team: if the component is not relevant please change it to a more appropriate one.

Regards,
Jerónimo.

Comment 3

[Jeronimo Torti (Please send NI request to Brindusa Tot)]

Hi,
I closed this ticket due to lack of information as Resolved-Incomplete. If the issue is still reproducible with the latest Firefox version, feel free to reopen the bug with more information.

Regards,
Jerónimo.