1724622 - Protections popup toast is missing a fade/cancel animation

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P5)

Description

[Shane Hughes [:aminomancer]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

• Click the tracking protection icon.
• Click the toggle.

Actual results:

• The tracking protection toast popup appears...
• It fades in and translates down 70px like a normal panel...
• But after 3 seconds, it just disappears instantaneously without a fade animation.

Expected results:

I think this is because the script uses PanelMultiView.hidePopup instead of this._protectionsPopup.hidePopup(true). I tried changing this one line and it fixed the problem for me. So I think line 2151 should just be changed from this:

PanelMultiView.hidePopup(this._protectionsPopup);

to this:

this._protectionsPopup.hidePopup(true);

Comment 1

[Release mgmt bot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Protections UI' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Shane Hughes [:aminomancer]]

Attachment: Bug 1724622 - Fix missing ETP toast popup animation. r=pbz

When the tracking protection toast popup closes on a timer, it doesn't
smoothly fade out, because it uses PanelMultiView.hidePopup instead of
panelNode.hidePopup. The static method on PanelMultiView ultimately
calls panelNode.hidePopup, but it doesn't have a parameter for enabling
the animation so it passes nothing to that method. This patch extends
PanelMultiView's hidePopup class methods to add an optional animate
parameter, and adds that parameter to the toast popup's hidePopup call.
This should slightly reduce the speed of part of
browser_protectionsUI.js but I don't think it affects any other tests.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31b0368654db
Fix missing ETP toast popup animation. r=pbz,Gijs

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/31b0368654db