1724633 - Search box in filter list dialog no more themed

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

The changes in bug 1715128 are now stricter and the search box needs now the themeableSearchBox class.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1724633-filterList-searchBox.patch

Without the patch the search box is still white with dark TB theme.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9235304 [details] [diff] [review]
1724633-filterList-searchBox.patch

Review of attachment 9235304 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a8a7f64233d5
Make the Filter list search box themeable again. r=aleca

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9235304 [details] [diff] [review]
1724633-filterList-searchBox.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1715128
User impact if declined: not correctly styled search box in filter list dialog when using dark theme
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9235304 [details] [diff] [review]
1724633-filterList-searchBox.patch

[Triage Comment]
Approved for 92.0b1

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 92.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/b889c96d8341