Plumb key system to CDM creation
Categories
(Core :: Audio/Video: GMP, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: bryce, Assigned: bryce)
References
Details
Attachments
(2 files)
Let's plumb the key system we're using to CDM when we create it. This is one of the steps we need to take to support a configurable clearkey CDM where we can toggle test features on or off.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1721411#c2 for context.
|
Assignee | |
Comment 1•3 years ago
|
||
Right now, GetCDM is only called with aTags containing a key system string. This
patch changes the function args to reflect that. This makes it easier to reason
about the function without having to look up call sites.
|
|
Assignee | |
Comment 2•3 years ago
|
||
This enables us to use CDMs that support multiple key systems. E.g. if we have a
CDM that supports keySystem1 and keySystem2, and it needs to know which key
system we want, this lets us tell it which.
This exact case can be used to let us have a more flexible and configurable
clearkey CDM with differently behaved key systems for specific tests.
Depends on D122136
Pushed by bvandyk@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1744680ee04d Instead of tags, accept a key system as an argument to GeckoMediaPluginService::GetCDM. r=alwu https://hg.mozilla.org/integration/autoland/rev/8100f4674794 Plumb key system arg to CDM creation. r=alwu
|
||
Comment 4•3 years ago
|
||
Backed out for GTest failure on ChromiumCDMAdapter.cpp
Backout link: https://hg.mozilla.org/integration/autoland/rev/3f1a146c7ca23a3ca7cc23691981b38efff14b63
Log link: https://treeherder.mozilla.org/logviewer?job_id=347982391&repo=autoland&lineNumber=31365
|
|
Assignee | |
Comment 5•3 years ago
|
||
Thanks. I suspect this is needing the "fake" key system in the assert as well. Will loop back on this once I iron out some WIP.
Pushed by bvandyk@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cabdc91d6c0a Instead of tags, accept a key system as an argument to GeckoMediaPluginService::GetCDM. r=alwu https://hg.mozilla.org/integration/autoland/rev/e2a8ba429f03 Plumb key system arg to CDM creation. r=alwu
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cabdc91d6c0a
https://hg.mozilla.org/mozilla-central/rev/e2a8ba429f03
|
|
Assignee | |
Updated•3 years ago
|
Description
•