Closed Bug 1724761 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29947 - Highlight API: Invalidate Highlights before paint

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29947 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29947
Details from upstream follow.

b'Fernando Fiori <ffiori@microsoft.com>' wrote:

Highlight API: Invalidate Highlights before paint

  • Move ValidateHighlightMarkers() call from paint phase to prepaint phase.

By rebuilding HighlightMarkers in paint phase there was invalidation
that would be repainted in the next frame paint, which wasn't being
triggered unless there was some external interaction or DOM
manipulation. Now this step is performed in prepaint, allowing
invalidated nodes to be repainted in this frame update.

Change-Id: I042913b823141f2b4c15c0206f227a6b623a4d35
Reviewed-on: https://chromium-review.googlesource.com/3082151
WPT-Export-Revision: 863e3b6bc5f9b3e7b136187813391d2598f7a920

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests

Status Summary

Firefox

PASS: 1
FAIL: 5

Chrome

PASS: 1
FAIL: 5

Safari

PASS: 1
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-highlight-api/painting/custom-highlight-painting-invalidation-001.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-highlight-api/painting/custom-highlight-painting-invalidation-003.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-highlight-api/painting/custom-highlight-painting-invalidation-004.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-highlight-api/painting/custom-highlight-painting-invalidation-005.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-highlight-api/painting/custom-highlight-painting-invalidation-006.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c26da8d63eab
[wpt PR 29947] - Highlight API: Invalidate Highlights before paint, a=testonly
https://hg.mozilla.org/integration/autoland/rev/765b69dbb338
[wpt PR 29947] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c26da8d63eab
https://hg.mozilla.org/mozilla-central/rev/765b69dbb338

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.