Closed
Bug 1724770
Opened 3 years ago
Closed 3 years ago
Perma esr91 xpcshell toolkit/components/telemetry/tests/unit/test_ModulesPing.js | test_send_ping - [test_send_ping : 243] The version of the xul.dll module (91.0.1.0) is correct (it starts with '91.1'). - false == true
Categories
(Toolkit :: Telemetry, defect, P5)
Tracking
()
RESOLVED
FIXED
93 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox-esr91 | --- | fixed |
| firefox91 | --- | wontfix |
| firefox92 | --- | fixed |
| firefox93 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: toshi)
References
(Regression)
Details
(Keywords: intermittent-failure, regression)
Attachments
(2 files)
|
Bug 1724770 - Fix a format string for AppendPrintf in SharedLibraryInfo::GetInfoForSelf()". r=gerald
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
Bug 1724770 - Fix a format string for AppendPrintf in SharedLibraryInfo::GetInfoForSelf()". r=gerald
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-esr91+
|
Details | Review |
Filed by: imoraru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=347855367&repo=mozilla-esr91
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/EX2Z_ag7TPugIe63uPnvRg/runs/0/artifacts/public/logs/live_backing.log
[task 2021-08-09T17:22:26.629Z] 17:22:26 INFO - TEST-START | toolkit/components/telemetry/tests/unit/test_ModulesPing.js
[task 2021-08-09T17:22:26.660Z] 17:22:26 INFO - TEST-PASS | toolkit/components/telemetry/tests/unit/test_TelemetryTimestamps.js | took 10831ms
[task 2021-08-09T17:22:26.680Z] 17:22:26 INFO - TEST-START | toolkit/components/telemetry/tests/unit/test_PingSender.js
[task 2021-08-09T17:22:28.025Z] 17:22:28 INFO - TEST-PASS | toolkit/components/telemetry/tests/unit/test_PingSender.js | took 1345ms
[task 2021-08-09T17:22:28.038Z] 17:22:28 INFO - TEST-START | toolkit/components/telemetry/tests/unit/test_TelemetryAndroidEnvironment.js
[task 2021-08-09T17:22:36.172Z] 17:22:36 INFO - TEST-PASS | toolkit/components/telemetry/tests/unit/test_TelemetryEvents_buildFaster.js | took 10818ms
[task 2021-08-09T17:22:36.189Z] 17:22:36 INFO - TEST-START | toolkit/components/telemetry/tests/unit/test_TelemetryUtils.js
[task 2021-08-09T17:22:36.487Z] 17:22:36 INFO - TEST-PASS | toolkit/components/telemetry/tests/unit/test_TelemetryUtils.js | took 298ms
[task 2021-08-09T17:22:36.492Z] 17:22:36 INFO - TEST-START | toolkit/components/telemetry/tests/unit/test_ThirdPartyModulesPing.js
[task 2021-08-09T17:22:36.492Z] 17:22:36 INFO - TEST-SKIP | toolkit/components/telemetry/tests/unit/test_ThirdPartyModulesPing.js | took 0ms
[task 2021-08-09T17:22:36.498Z] 17:22:36 INFO - TEST-START | toolkit/components/telemetry/tests/unit/test_EventPing.js
[task 2021-08-09T17:22:38.410Z] 17:22:38 INFO - TEST-PASS | toolkit/components/telemetry/tests/unit/test_TelemetryAndroidEnvironment.js | took 10371ms
[task 2021-08-09T17:22:38.420Z] 17:22:38 INFO - TEST-START | toolkit/components/telemetry/tests/unit/test_CoveragePing.js
[task 2021-08-09T17:22:38.697Z] 17:22:38 INFO - TEST-TIMEOUT | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_cors_mozextension.js | took 300001ms
[task 2021-08-09T17:22:38.702Z] 17:22:38 INFO - TEST-TIMEOUT | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_contentscript_xml_prettyprint.js | took 300002ms
[task 2021-08-09T17:22:38.708Z] 17:22:38 INFO - TEST-TIMEOUT | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_contentscript_teardown.js | took 300002ms
[task 2021-08-09T17:22:38.709Z] 17:22:38 INFO - TEST-TIMEOUT | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_contentscript_unregister_during_loadContentScript.js | took 300002ms
[task 2021-08-09T17:22:38.709Z] 17:22:38 INFO - TEST-TIMEOUT | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_downloads.js | took 300001ms
[task 2021-08-09T17:22:38.720Z] 17:22:38 INFO - TEST-TIMEOUT | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_contentscript_exporthelpers.js | took 300003ms
[task 2021-08-09T17:22:38.726Z] 17:22:38 INFO - TEST-TIMEOUT | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_contentscript_in_background.js | took 300000ms
[task 2021-08-09T17:22:38.730Z] 17:22:38 INFO - TEST-TIMEOUT | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_contentscript_restrictSchemes.js | took 300007ms
[task 2021-08-09T17:22:38.733Z] 17:22:38 INFO - TEST-TIMEOUT | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_debugging_utils.js | took 300005ms
[task 2021-08-09T17:22:38.751Z] 17:22:38 INFO - Error 0x8007012B in MiniDumpWriteDump
[task 2021-08-09T17:22:38.757Z] 17:22:38 INFO - xpcshell return code: None
[task 2021-08-09T17:22:38.764Z] 17:22:38 INFO - TEST-TIMEOUT | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_dns.js | took 300010ms
[task 2021-08-09T17:22:38.947Z] 17:22:38 INFO - xpcshell return code: None
[task 2021-08-09T17:22:38.951Z] 17:22:38 INFO - xpcshell return code: None
[task 2021-08-09T17:22:38.952Z] 17:22:38 INFO - xpcshell return code: None
[task 2021-08-09T17:22:38.952Z] 17:22:38 INFO - xpcshell return code: None
[task 2021-08-09T17:22:38.954Z] 17:22:38 INFO - xpcshell return code: None
[task 2021-08-09T17:22:38.963Z] 17:22:38 INFO - xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_contentscript_in_background.js failed or timed out, will retry.
[task 2021-08-09T17:22:38.969Z] 17:22:38 INFO - xpcshell return code: None
[task 2021-08-09T17:22:38.977Z] 17:22:38 INFO - xpcshell return code: None
[task 2021-08-09T17:22:38.980Z] 17:22:38 INFO - xpcshell return code: None
[task 2021-08-09T17:22:38.981Z] 17:22:38 INFO - xpcshell return code: None
[task 2021-08-09T17:22:39.007Z] 17:22:39 INFO - TEST-TIMEOUT | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_downloads_search.js | took 300002ms
[task 2021-08-09T17:22:39.129Z] 17:22:39 INFO - xpcshell return code: None
[task 2021-08-09T17:22:39.378Z] 17:22:39 INFO - TEST-FAIL | toolkit/components/telemetry/tests/unit/test_ModulesPing.js | took 12748ms
[task 2021-08-09T17:22:39.389Z] 17:22:39 INFO - toolkit/components/telemetry/tests/unit/test_ModulesPing.js failed or timed out, will retry.
[task 2021-08-09T17:22:47.142Z] 17:22:47 INFO - TEST-PASS | toolkit/components/telemetry/tests/unit/test_EventPing.js | took 10644ms
[task 2021-08-09T17:22:49.018Z] 17:22:49 INFO - TEST-START | toolkit/components/telemetry/tests/unit/test_bug1555798.js
<...>
[task 2021-08-09T17:30:40.934Z] 17:30:40 INFO - TEST-START | toolkit/components/telemetry/tests/unit/test_ModulesPing.js
[task 2021-08-09T17:30:53.283Z] 17:30:53 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_ModulesPing.js | xpcshell return code: 0
[task 2021-08-09T17:30:53.284Z] 17:30:53 INFO - TEST-INFO took 12350ms
[task 2021-08-09T17:30:53.284Z] 17:30:53 INFO - >>>>>>>
[task 2021-08-09T17:30:53.284Z] 17:30:53 INFO - PID 15984 | [Parent 15984, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp:120
[task 2021-08-09T17:30:53.284Z] 17:30:53 INFO - PID 15984 | [Parent 15984, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp:120
[task 2021-08-09T17:30:53.285Z] 17:30:53 INFO - PID 15984 | [Parent 15984, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp:120
[task 2021-08-09T17:30:53.285Z] 17:30:53 INFO - PID 15984 | [Parent 15984, Main Thread] WARNING: Failed to get directory to cache.: file /builds/worker/checkouts/gecko/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp:120
[task 2021-08-09T17:30:53.285Z] 17:30:53 INFO - PID 15984 | [Parent 15984, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:2948
[task 2021-08-09T17:30:53.285Z] 17:30:53 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2021-08-09T17:30:53.286Z] 17:30:53 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2021-08-09T17:30:53.286Z] 17:30:53 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2021-08-09T17:30:53.286Z] 17:30:53 INFO - running event loop
[task 2021-08-09T17:30:53.286Z] 17:30:53 INFO - toolkit/components/telemetry/tests/unit/test_ModulesPing.js | Starting setup
[task 2021-08-09T17:30:53.286Z] 17:30:53 INFO - (xpcshell/head.js) | test setup pending (2)
[task 2021-08-09T17:30:53.287Z] 17:30:53 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2021-08-09T17:30:53.287Z] 17:30:53 INFO - PID 15984 | [Parent 15984, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, kKnownEsrVersion) failed with result 0x80004002 (NS_NOINTERFACE): file /builds/worker/checkouts/gecko/toolkit/components/resistfingerprinting/nsRFPService.cpp:553
[task 2021-08-09T17:30:53.287Z] 17:30:53 INFO - PID 15984 | LdrLoadDll: len too long! 129
[task 2021-08-09T17:30:53.287Z] 17:30:53 INFO - (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2021-08-09T17:30:53.287Z] 17:30:53 INFO - (xpcshell/head.js) | test setup finished (2)
[task 2021-08-09T17:30:53.288Z] 17:30:53 INFO - toolkit/components/telemetry/tests/unit/test_ModulesPing.js | Starting test_send_ping
[task 2021-08-09T17:30:53.288Z] 17:30:53 INFO - (xpcshell/head.js) | test test_send_ping pending (2)
[task 2021-08-09T17:30:53.288Z] 17:30:53 INFO - (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2021-08-09T17:30:53.288Z] 17:30:53 INFO - "CONSOLE_MESSAGE: (info) 1628530241208 Toolkit.Telemetry TRACE TelemetryController::setupTelemetry"
<...>
[task 2021-08-09T17:30:53.320Z] 17:30:53 INFO - TEST-PASS | toolkit/components/telemetry/tests/unit/test_ModulesPing.js | test_send_ping - [test_send_ping : 213] Telemetry ping payload contains the 'modules' array. - true == true
[task 2021-08-09T17:30:53.320Z] 17:30:53 INFO - TEST-PASS | toolkit/components/telemetry/tests/unit/test_ModulesPing.js | test_send_ping - [test_send_ping : 239] There is a 'xul.dll' module. - true == true
[task 2021-08-09T17:30:53.321Z] 17:30:53 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_ModulesPing.js | test_send_ping - [test_send_ping : 243] The version of the xul.dll module (91.0.1.0) is correct (it starts with '91.1'). - false == true
[task 2021-08-09T17:30:53.321Z] 17:30:53 INFO - Z:/task_1628527431/build/tests/xpcshell/tests/toolkit/components/telemetry/tests/unit/test_ModulesPing.js:test_send_ping:243
[task 2021-08-09T17:30:53.321Z] 17:30:53 INFO - Z:\task_1628527431\build\tests\xpcshell\head.js:_do_main:240
[task 2021-08-09T17:30:53.321Z] 17:30:53 INFO - Z:\task_1628527431\build\tests\xpcshell\head.js:_execute_test:597
[task 2021-08-09T17:30:53.321Z] 17:30:53 INFO - -e:null:1
[task 2021-08-09T17:30:53.321Z] 17:30:53 INFO - exiting test
[task 2021-08-09T17:30:53.322Z] 17:30:53 INFO - Unexpected exception NS_ERROR_ABORT:
[task 2021-08-09T17:30:53.322Z] 17:30:53 INFO - _abort_failed_test@Z:\task_1628527431\build\tests\xpcshell\head.js:860:20
[task 2021-08-09T17:30:53.322Z] 17:30:53 INFO - do_report_result@Z:\task_1628527431\build\tests\xpcshell\head.js:961:5
[task 2021-08-09T17:30:53.322Z] 17:30:53 INFO - Assert<@Z:\task_1628527431\build\tests\xpcshell\head.js:75:21
[task 2021-08-09T17:30:53.322Z] 17:30:53 INFO - proto.report@resource://testing-common/Assert.jsm:228:10
[task 2021-08-09T17:30:53.323Z] 17:30:53 INFO - proto.ok@resource://testing-common/Assert.jsm:254:10
[task 2021-08-09T17:30:53.323Z] 17:30:53 INFO - test_send_ping@Z:/task_1628527431/build/tests/xpcshell/tests/toolkit/components/telemetry/tests/unit/test_ModulesPing.js:243:18
[task 2021-08-09T17:30:53.323Z] 17:30:53 INFO - _do_main@Z:\task_1628527431\build\tests\xpcshell\head.js:240:6
[task 2021-08-09T17:30:53.323Z] 17:30:53 INFO - _execute_test@Z:\task_1628527431\build\tests\xpcshell\head.js:597:5
[task 2021-08-09T17:30:53.323Z] 17:30:53 INFO - @-e:1:1
[task 2021-08-09T17:30:53.324Z] 17:30:53 INFO - exiting test
[task 2021-08-09T17:30:53.324Z] 17:30:53 INFO - "CONSOLE_MESSAGE: (info) 1628530243147 Toolkit.Telemetry TRACE PingServer::defaultPingHandler() - POST http://localhost:59101/submit/telemetry/2466770e-588f-4f94-b865-ac3e38464cd2/modules///default/"
[task 2021-08-09T17:30:53.324Z] 17:30:53 INFO - "CONSOLE_MESSAGE: (info) 1628530243178 Toolkit.Telemetry INFO TelemetrySend::_doPing - successfully loaded, status: 200"
[task 2021-08-09T17:30:53.324Z] 17:30:53 INFO - "CONSOLE_MESSAGE: (info) 1628530243178 Toolkit.Telemetry TRACE TelemetrySend::_onPingRequestFinished - success: true, persisted: false"
[task 2021-08-09T17:30:53.325Z] 17:30:53 INFO - "CONSOLE_MESSAGE: (info) 1628530243179 Toolkit.Telemetry TRACE TelemetrySend::Scheduler::_doSendTask - bailing out after sending, shutdown: false, pendingPingCount: 0"
[task 2021-08-09T17:30:53.325Z] 17:30:53 INFO - "CONSOLE_MESSAGE: (info) 1628530243181 Toolkit.Telemetry TRACE TelemetryEnvironment::observe - aTopic: nsPref:changed, aData: network.trr.blocklist_cleanup_done"
[task 2021-08-09T17:30:53.325Z] 17:30:53 INFO - PID 15984 | [Parent 15984, Socket Thread] WARNING: cannot post e
[task 2021-08-09T17:30:53.325Z] 17:30:53 INFO - "CONSOLE_MESSAGE: (info) 1628530243187 Toolkit.Telemetry TRACE TelemetrySend::Scheduler::shutdown"
[task 2021-08-09T17:30:53.326Z] 17:30:53 INFO - PID 15984 | vent if not initialized: file /builds/worker/checkouts/gecko/netwerk/protocol/
[task 2021-08-09T17:30:53.326Z] 17:30:53 INFO - "CONSOLE_MESSAGE: (info) 1628530243187 Toolkit.Telemetry TRACE TelemetrySend::promisePendingPingActivity - Waiting for ping task"
[task 2021-08-09T17:30:53.326Z] 17:30:53 INFO - PID 15984 | http/nsHttpConnectionMgr.cpp:196
[task 2021-08-09T17:30:53.326Z] 17:30:53 INFO - PID 15984 | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2021-08-09T17:30:53.327Z] 17:30:53 INFO - PID 15984 | [Parent 15984, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3357
[task 2021-08-09T17:30:53.327Z] 17:30:53 INFO - PID 15984 | Destroying context 0DD0B000 surface 05B3B2E0 on display 05B17C00
[task 2021-08-09T17:30:53.327Z] 17:30:53 INFO - PID 15984 | [GPU 19096, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4438
[task 2021-08-09T17:30:53.328Z] 17:30:53 INFO - PID 15984 | [Parent 15984, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4438
[task 2021-08-09T17:30:53.328Z] 17:30:53 INFO - <<<<<<<
[task 2021-08-09T17:30:53.390Z] 17:30:53 INFO - TEST-START | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_contentscript_in_background.js
|
||
Updated•3 years ago
|
Summary: Intermittent Perma esr91 xpcshell toolkit/components/telemetry/tests/unit/test_ModulesPing.js | test_send_ping - [test_send_ping : 243] The version of the xul.dll module (91.0.1.0) is correct (it starts with '91.1'). - false == true → Perma esr91 xpcshell toolkit/components/telemetry/tests/unit/test_ModulesPing.js | test_send_ping - [test_send_ping : 243] The version of the xul.dll module (91.0.1.0) is correct (it starts with '91.1'). - false == true
|
||
Comment 1•3 years ago
|
||
Oddly this only seems to be impacting win32 builds.
|
|
||
Comment 2•3 years ago
|
||
Downloading the appropriate target.zip referenced by the logs, xul.dll has the correct version number from what I can see.
|
|
||
Comment 3•3 years ago
|
||
Mike, do you have any idea what might be going wrong here, and only on win32?
Flags: needinfo?(mh+mozilla)
|
||
Comment 4•3 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #2)
Downloading the appropriate target.zip referenced by the logs, xul.dll has the correct version number from what I can see.
what correct version number does it have?
Flags: needinfo?(mh+mozilla) → needinfo?(ryanvm)
|
|
||
Comment 5•3 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #4)
what correct version number does it have?
91.1.0.x (where x depends on the specific build)
Flags: needinfo?(ryanvm)
|
|
||
Comment 6•3 years ago
|
||
And the RC file is correct:
1 VERSIONINFO
FILEVERSION 91,1,0,7891
PRODUCTVERSION 91,1,0,7891
Could the part reading the version from PEHeaders be getting it wrong?
Flags: needinfo?(tkikuchi)
|
Assignee | |
Comment 7•3 years ago
|
||
Finally I got the root cause. We retrieve the version info correctly, but there is a type confusion when passing integers to AppendPrintf!
Flags: needinfo?(tkikuchi)
Regressed by: 1702086
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
|
|
||
Updated•3 years ago
|
status-firefox91:
--- → affected
status-firefox92:
--- → affected
status-firefox93:
--- → affected
status-firefox-esr78:
--- → unaffected
status-firefox-esr91:
--- → affected
|
|
Assignee | |
Comment 8•3 years ago
|
||
We passed 64-bit integer arguments, but AppendPrintf took them
as 32-bit parameters.
|
||
Updated•3 years ago
|
Assignee: nobody → tkikuchi
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•3 years ago
|
OS: Unspecified → Windows
Hardware: Unspecified → x86
|
|
||
Updated•3 years ago
|
Attachment #9236225 -
Attachment description: Bug 1724770 - Make sure 32-bit integers are passed to AppendPrintf. r=gerald → Bug 1724770 - Fix a format string for AppendPrintf in SharedLibraryInfo::GetInfoForSelf()". r=gerald
Pushed by tkikuchi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e6a3830a56af Fix a format string for AppendPrintf in SharedLibraryInfo::GetInfoForSelf()". r=gerald
|
|
||
Comment 10•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
|
|
||
Comment 11•3 years ago
•
|
||
Please nominate this for Beta & ESR91 approval when you get a chance.
Flags: needinfo?(tkikuchi)
| Comment hidden (Intermittent Failures Robot) |
|
|
Assignee | |
Comment 13•3 years ago
|
||
We passed 64-bit integer arguments, but AppendPrintf took them
as 32-bit parameters. This generated a wrong version string in
32bit build.
|
|
Assignee | |
Comment 14•3 years ago
|
||
Comment on attachment 9236493 [details]
Bug 1724770 - Fix a format string for AppendPrintf in SharedLibraryInfo::GetInfoForSelf()". r=gerald
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: We will receive wrong version data in the modules ping and in the third-party modules ping.
- User impact if declined: There is no visible symptom to users.
- Fix Landed on Version: 93
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The fix is to explicitly static cast a 64-bit integer into a 32-bit integer. The regression risk is trivial.
- String or UUID changes made by this patch: None
Beta/Release Uplift Approval Request
- User impact if declined: There is no visible symptom to users. With the defect, we receive wrong version data in the modules ping and in the third-party modules ping, and GTest on x86 fails.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The fix is to explicitly static cast a 64-bit integer into a 32-bit integer. The regression risk is trivial.
- String changes made/needed: None
Flags: needinfo?(tkikuchi)
Attachment #9236493 -
Flags: approval-mozilla-esr91?
Attachment #9236493 -
Flags: approval-mozilla-beta?
|
|
||
Updated•3 years ago
|
|
|
||
Comment 15•3 years ago
|
||
Comment on attachment 9236493 [details]
Bug 1724770 - Fix a format string for AppendPrintf in SharedLibraryInfo::GetInfoForSelf()". r=gerald
Approved for 92.0b5 and 91.1esr.
Attachment #9236493 -
Flags: approval-mozilla-esr91?
Attachment #9236493 -
Flags: approval-mozilla-esr91+
Attachment #9236493 -
Flags: approval-mozilla-beta?
Attachment #9236493 -
Flags: approval-mozilla-beta+
|
|
||
Comment 16•3 years ago
|
||
| bugherder uplift | ||
|
|
||
Comment 17•3 years ago
|
||
| bugherder uplift | ||
|
||
Updated•3 years ago
|
Keywords: regression
| Comment hidden (Intermittent Failures Robot) |
|
||
Comment 19•3 years ago
|
||
I am a bit confused.
On try-comm-central server, I still see this issue.
My try-comm-central server submission.
Please look at Windows 10 x64 opt log. X2
[task 2021-09-06T15:59:13.177Z] 15:59:13 INFO - TEST-PASS | toolkit/components/telemetry/tests/unit/test_ModulesPing.js | test_send_ping - [test_send_ping : 233] There is a 'xul.dll' module. - true == true
[task 2021-09-06T15:59:13.177Z] 15:59:13 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_ModulesPing.js | test_send_ping - [test_send_ping : 237] The version of the xul.dll module (94.0.0.7919) is correct (it starts with '93.0'). - false == true
[task 2021-09-06T15:59:13.177Z] 15:59:13 INFO - Z:/task_1630943173/build/tests/xpcshell/tests/toolkit/components/telemetry/tests/unit/test_ModulesPing.js:test_send_ping:237
[task 2021-09-06T15:59:13.178Z] 15:59:13 INFO - Z:\task_1630943173\build\tests\xpcshell\head.js:_do_main:240
[task 2021-09-06T15:59:13.178Z] 15:59:13 INFO - Z:\task_1630943173\build\tests\xpcshell\head.js:_execute_test:597
[task 2021-09-06T15:59:13.178Z] 15:59:13 INFO - -e:null:1
[task 2021-09-06T15:59:13.178Z] 15:59:13 INFO - exiting test
[task 2021-09-06T15:59:13.178Z] 15:59:13 INFO - Unexpected exception NS_ERROR_ABORT:
Will try-comm-central servers get this update until later?
Or have they slipped through maintenance fingers?
Oh, no. The version strings are now different (!) upon closer inspection.
The version of the xul.dll module (94.0.0.7919) is correct (it starts with '93.0'). - false == true
We may want a mechanism to change these version strings in tests appropriately from time to time.
Maybe I should submit a new bugzilla.
|
|
Assignee | |
Comment 20•3 years ago
|
||
(In reply to ISHIKAWA, Chiaki from comment #19)
Oh, no. The version strings are now different (!) upon closer inspection.
The version of the xul.dll module (94.0.0.7919) is correct (it starts with '93.0'). - false == trueWe may want a mechanism to change these version strings in tests appropriately from time to time.
Maybe I should submit a new bugzilla.
That version difference looks like a different issue. This bug was something like printf("%d.%d", static_cast<uint64_t>(93), 1);, which outputs 93.0 in x86 build instead of 93.1.
You need to log in
before you can comment on or make changes to this bug.
Description
•