Closed Bug 1724773 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29948 - Don't modify computed value of 'contain' for locked elements

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29948 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29948
Details from upstream follow.

b'Anders Hartvoll Ruud <andruud@chromium.org>' wrote:

Don't modify computed value of 'contain' for locked elements

DisplayLockContext::AdjustElementStyle currently modifies the computed
value of 'contain'. It should not [1].

Instead we store a bit on ComputedStyle to indicate whether or not
the element should skip its contents [2], and use this flag used-
value-time to request the appropriate containment.

[1] https://github.com/w3c/csswg-drafts/issues/6246
[2] https://drafts.csswg.org/css-contain-2/#skips-its-contents

Change-Id: I5571b0a5fac1b89903c03a256a2b144bddcd5040
Reviewed-on: https://chromium-review.googlesource.com/3081725
WPT-Export-Revision: 4feaaea34e50d117370ac0c0a5ed30d561a39c1c

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-contain/content-visibility/content-visibility-026.html
content-visibility:hidden does not affect computed value of 'contain': FAIL (Chrome: FAIL, Safari: FAIL)
content-visibility:auto does not affect computed value of 'contain': FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9370289938db
[wpt PR 29948] - Don't modify computed value of 'contain' for locked elements, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3890fccd876b
[wpt PR 29948] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9370289938db
https://hg.mozilla.org/mozilla-central/rev/3890fccd876b

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.