1724839 - Remove BasicLayerManager usage from Paint functions

Status: RESOLVED FIXED

(Core :: Web Painting, task)

Description

[Matt Woodrow (:mattwoodrow)]

We currently use a temporary BasicLayerManager (without FrameLayerBuilder), in order to do fallback painting of videos and canvas elements.

We should remove this, so that we can remove BasicLayerManager entirely.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1724839 - Don't use BasicLayerManager for painting ImageBitmap <canvas> elements. r?jrmuizel

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1724839 - Don't use BasicLayerManager for painting CanvasRenderer backed canvas elements. r?jrmuizel

Depends on D122171

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1724839 - Don't use BasicLayerManager to paint video elements. r?jrmuizel

Depends on D122172

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1724839 - Move transform snapping code into gfxUtils. r?jrmuizel

Depends on D122173

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1724839 - Add 2d matrix equivalents for transform snapping functions. r?jrmuizel

Depends on D122174

Comment 6

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1724839 - Snap transforms for video/canvas painting in the same way that Layer rendering did. r?jrmuizel

This takes the logic used for Image/CanvasLayer::ComputeEffectiveTransforms and uses it to get matching rendering for the Paint path.

Depends on D122175

Comment 7

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1724839 - Mark tests as passing. r?jrmuizel

Depends on D122176

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffc97ce6e2fe
Don't use BasicLayerManager for painting ImageBitmap <canvas> elements. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/052d8f8f2306
Don't use BasicLayerManager for painting CanvasRenderer backed canvas elements. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8ed5600c10c5
Don't use BasicLayerManager to paint video elements. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/f10f423b3cd1
Move transform snapping code into gfxUtils. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8179eecebbbd
Add 2d matrix equivalents for transform snapping functions. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/1b3f01bb4409
Snap transforms for video/canvas painting in the same way that Layer rendering did. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/34f47ed38272
Mark tests as passing. r=jrmuizel

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ffc97ce6e2fe
https://hg.mozilla.org/mozilla-central/rev/052d8f8f2306
https://hg.mozilla.org/mozilla-central/rev/8ed5600c10c5
https://hg.mozilla.org/mozilla-central/rev/f10f423b3cd1
https://hg.mozilla.org/mozilla-central/rev/8179eecebbbd
https://hg.mozilla.org/mozilla-central/rev/1b3f01bb4409
https://hg.mozilla.org/mozilla-central/rev/34f47ed38272