1724878 - Search mode chiclet close button in address bar has low contrast in dark mode

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Kestrel]

Attachment: Search mode chiclet with dark theme

STR:

1. Enable Dark theme.
2. Type "duck" in the address bar and press Tab to select "Search with DuckDuckGo".

The search mode chiclet close symbol is black on a dark background making it difficult to see.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6ffeb2a3d80381264c0ad9329b4d07b3f343a4ca&tochange=c7687ceeff3f99555aa7d3f744da33952aef236f

Regressed by Bug 1698814.

Comment 1

[Dão Gottwald [:dao]]

Harry, would you look into this?

Comment 2

[Harry Twyford]

[Tracking Requested - why for this release]:
Minor UI regression that causes low contrast on an element.

Comment 3

[Harry Twyford]

Attachment: Bug 1724878 - Apply fill:currentColor to #urlbar-search-mode-indicator-close. r?dao!

This fixes the bug but retains the fix for the unfiled bug I mentioned in this Phabricator comment. Basically we want fill:var(--toolbar-field-color) when the Urlbar is unfocused and fill:var(--toolbar-field-focus-color) when it's focused.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97a6a6951ad6
Apply fill:currentColor to #urlbar-search-mode-indicator-close. r=dao

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/97a6a6951ad6

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:harry, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Harry Twyford]

Comment on attachment 9235989 [details]
Bug 1724878 - Apply fill:currentColor to #urlbar-search-mode-indicator-close. r?dao!

Beta/Release Uplift Approval Request

• User impact if declined: Minor contrast regression in the address bar. See screenshot in comment 0.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-line CSS change.
• String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9235989 [details]
Bug 1724878 - Apply fill:currentColor to #urlbar-search-mode-indicator-close. r?dao!

Approved for 92.0b5.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d4e96a6b136a

Comment 10

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed in the latest Fx 93.0a1 nightly and latest beta Fx92.0b9 on Windows 10 and Ubuntu 20.04. The 'close' button for the chiclet is correctly displayed.