Closed Bug 1724885 Opened 5 months ago Closed 5 months ago

[MSIX] Missing Firefox icon in windows taskbar, apps, apps & features

Categories

(Firefox :: Installer, defect)

Firefox 92
Desktop
Windows 11
defect

Tracking

()

VERIFIED FIXED
93 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox91 --- unaffected
firefox92 --- verified
firefox93 --- verified

People

(Reporter: csasca, Assigned: nalexander)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image msix no icon.png

Affected versions

  • Firefox 92.0b1 MSIX installer

Affected platforms

  • Windows 11

Steps to reproduce
1.Install MSIX build

Expected result

  • The Firefox icon can be found in Apps and Features, All apps, Taskbar, etc in Windows

Actual result

  • A blank icon is shown

Regression range

  • First beta MSIX build

Additional notes

  • The issue can be seen in the attachment
Has Regression Range: --- → no
Has STR: --- → yes

Well, that's interesting. There must be some beta-specific wrinkle here, since I'm fairly confident iconography for Nightly builds is green. I'll track this down.

Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Regressed by: 1709697

When relanding Bug 1709697, all of the icons ended up as 0-byte files.
I can't explain this; it's hard to achieve this with a rebase. We
regenerate Resources.pri following the instructions in the
documentation.

This commit also moves to represent the package as "Mozilla Firefox",
which is consistent with how unpackaged versions appear in the Windows
UI. In the start menu, the application continues to be represented as
"Firefox" (no "Mozilla" vendor).

Finally, this commit also differentiates "Firefox Beta" from "Firefox"
in a few select places (while not changing branding and iconography).

Try build at https://treeherder.mozilla.org/jobs?repo=try&revision=1c67800d0ae29773266c916cebec25a32502985d looks healthy for me:

  • Start Menu icon is present
  • Taskbar icon is present
  • Document icon is present (i.e., a file saved to Desktop has the document icon)
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15feceafbc4a
Fix broken icons; differentiate Beta. r=mhowell
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

Verified that the icon is present now on 93.0a1 (2021-08-15) build on two separate systems with Windows 11.

Did you want to nominate this for Beta uplift, Nick?

Flags: needinfo?(nalexander)

Comment on attachment 9235905 [details]
Bug 1724885 - Fix broken icons; differentiate Beta. r?mhowell

Beta/Release Uplift Approval Request

  • User impact if declined: No icons in the Windows User Interface.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Nobody is consuming these MSIX packages at this time, so there can be no bustage.
  • String changes made/needed:
Flags: needinfo?(nalexander)
Attachment #9235905 - Flags: approval-mozilla-beta?

(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)

Did you want to nominate this for Beta uplift, Nick?

Yes -- thanks for the nudge.

Comment on attachment 9235905 [details]
Bug 1724885 - Fix broken icons; differentiate Beta. r?mhowell

Approved for 92.0b5.

Attachment #9235905 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified fixed with 92.0b6 (20210819173814) MSIX build on Windows 11x64. The Firefox icon is properly displayed.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.