1724962 - Implement highlighting History/Restore Previous Session items for one-time infobar from bug 1724960

Status: VERIFIED FIXED

(Firefox :: General, enhancement, P3)

Description

[:Gijs (he/him)]

We should be able to open the hamburger panel and highlight these items as per the UX spec.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Navigation' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Neil Deakin]

The patch here uses the UITour to highlight the History item in the menu. I'm not clear if anything else if expected here.

Comment 3

[Neil Deakin]

Attachment: Bug 1724962, show how button in session restore notification bar should open menu and highlight history item, r=gijs

Comment 4

[Neil Deakin]

Attachment: Bug 1724962 - add focus styling option to UI Tour and use it for the session restore infobar

Depends on D126730

Comment 5

[Neil Deakin]

Attachment: Bug 1724962, when the uitour highlight opens from the show how button on the session restore infobar, also highlight the restore session option from the history menu when it is opened, r=gijs

Depends on D127197

Comment 6

[Neil Deakin]

I think I might followup later with a version that doesn't use the uitour and instead focuses the menuitems instead.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1d1b7c83947
show how button in session restore notification bar should open menu and highlight history item, r=Gijs
https://hg.mozilla.org/integration/autoland/rev/c137494e2a6d
add focus styling option to UI Tour and use it for the session restore infobar r=NeilDeakin
https://hg.mozilla.org/integration/autoland/rev/caeccd766a43
when the uitour highlight opens from the show how button on the session restore infobar, also highlight the restore session option from the history menu when it is opened, r=Gijs

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b1d1b7c83947
https://hg.mozilla.org/mozilla-central/rev/c137494e2a6d
https://hg.mozilla.org/mozilla-central/rev/caeccd766a43

Comment 9

[Negritas Sergiu, Desktop QA]

Hello! I can confirm that the issue is fixed on Firefox 94.0b8 and 95.0a1 (2021-10-21) on MacOS, Windows 10 and Ubuntu 20.
I will update the flags and the resolution of this issue accordingly.

Thank you!