Closed Bug 172502 Opened 20 years ago Closed 18 years ago
Do not allow ctrl+dragging (or remove the + pointer) in Toolbar Customization
Using build 20021003 on WinXP Steps to Reproduce: 1. Go to Customize Toolbars. 2. Hold down Ctrl and drag an item (on the toolbar or in the dialog). 3. Mouse cursor has a +, indicating the item will be copied. Expected Results: Item gets copied. Actual Results: Item gets moved.
I don't think we want to copy the item (at least not most of them). But we should fix the pointer to not suggest a copy.
Assignee: hyatt → hewitt
Summary: Ctrl-dragging does not copy customization items → Ctrl-dragging does not copy customization items
Chris, is it alright with you if I morph this bug into "Do not allow ctrl+dragging or remove the + pointer". If not then I'll mark this won'tfix and file a new bug.
Fine by me.
Summary: Ctrl-dragging does not copy customization items → Do not allow ctrl+dragging (or remove the + pointer) in Toolbar Customization
Taking QA Contact
QA Contact: asa → bugzilla
This patch makes DROPEFFECT_MOVE the only valid action. If you try to copy the item by holding ctrl, you will get the "no" symbol (circle with a line through it) and the drop won't go through. That seems to be the standard windows way of indicating a drag-and-drop attempt is invalid. I can't find a way to make it simply ignore the ctrl press and always act like a move without mucking with Gecko's internals; see http://lxr.mozilla.org/aviarybranch/source/widget/src/windows/nsNativeDragTarget.cpp#211 if you're interested in why.
Comment on attachment 151848 [details] [diff] [review] Patch This is a trivial polish fix, but it makes us more consistent which is a good thing.
Attachment #151848 - Flags: review?(mconnor)
I'll look at this later tonight, almost done!
Comment on attachment 151848 [details] [diff] [review] Patch Actually, on linux it does what you want it to do (just drag with the right icon), if it just plain doesn't work on Windows that's fine, it'll clearly tell people trying to do it that it won't work.
Attachment #151848 - Flags: review?(mconnor) → review+
fixed branch and trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.