Closed Bug 1725056 Opened 3 years ago Closed 3 years ago

qcms: avoid undefined behavior when handling CICP values

Categories

(Core :: Graphics: Color Management, defect)

defect

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox92 --- fixed
firefox93 --- fixed

People

(Reporter: jbauman, Assigned: jbauman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Since there's no safe way to pass enum values across FFI, we'll need to adjust our approach from bug 1634741.

Attachment #9235737 - Attachment description: WIP: Bug 1725056 - qcms: avoid undefined behavior when handling CICP values. r=jrmuizel,tsmith → Bug 1725056 - qcms: avoid undefined behavior when handling CICP values. r=jrmuizel,tsmith
Pushed by jbauman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/969483aeeeb1
qcms: avoid undefined behavior when handling CICP values. r=jrmuizel,tsmith
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

Comment on attachment 9235737 [details]
Bug 1725056 - qcms: avoid undefined behavior when handling CICP values. r=jrmuizel,tsmith

Beta/Release Uplift Approval Request

  • User impact if declined: Possible undefined behavior
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Fundamentally, this is just moving the declaration of a few types around and making the underlying type explicit. It was the lack of an explicit underlying type previously that opened the door to UB.
  • String changes made/needed:
Attachment #9235737 - Flags: approval-mozilla-beta?

Comment on attachment 9235737 [details]
Bug 1725056 - qcms: avoid undefined behavior when handling CICP values. r=jrmuizel,tsmith

Approved for 92.0b8.

Attachment #9235737 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.