1725066 - undefined reference to `mozilla::Result<mozilla::Ok, JS::TranscodeResult> js::frontend::StencilXDR::codeSharedData<(js::XDRMode)0>(js::XDRState<(js::XDRMode)0>*, RefPtr<js::SharedImmutableScriptData>&)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Mike Hommey [:glandium]]

[task 2021-08-10T22:34:21.749Z] 22:34:21     INFO -  ../../../js/src/build/libjs_static.a(Unified_cpp_js_src22.o): in function `mozilla::Result<mozilla::Ok, JS::TranscodeResult> js::XDRScript<(js::XDRMode)0>(js::XDRState<(js::XDRMode)0>*, JS::Handle<js::Scope*>, JS::Handle<js::ScriptSourceObject*>, JS::Handle<JSObject*>, JS::MutableHandle<JSScript*>)':
[task 2021-08-10T22:34:21.750Z] 22:34:21     INFO -  /builds/worker/checkouts/gecko/js/src/vm/JSScript.cpp:1156: undefined reference to `mozilla::Result<mozilla::Ok, JS::TranscodeResult> js::frontend::StencilXDR::codeSharedData<(js::XDRMode)0>(js::XDRState<(js::XDRMode)0>*, RefPtr<js::SharedImmutableScriptData>&)'
[task 2021-08-10T22:34:21.750Z] 22:34:21     INFO -  /builds/worker/fetches/binutils/bin/ld.bfd: libxul.so: hidden symbol `_ZN2js8frontend10StencilXDR14codeSharedDataILNS_7XDRModeE0EEEN7mozilla6ResultINS4_2OkEN2JS15TranscodeResultEEEPNS_8XDRStateIXT_EEER6RefPtrINS_25SharedImmutableScriptDataEE' isn't defined

For some reason, this only happens on s390x, but there's no reason this couldn't happen any platform.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1725066 - Restore template instantiations that were removed in bug 1724803.

They're necessary because of cross-compilation-unit use of the
template.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1724803

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00e83f182733
Restore template instantiations that were removed in bug 1724803. r=tcampbell

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/00e83f182733