Closed Bug 1725093 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29982 - [TablesNG] Fix rowspan cell height distribution over percentage rows

Categories

(Core :: Layout: Tables, task, P4)

Product:
Core
Component:
Layout: Tables
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29982 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29982
Details from upstream follow.

b'Aleks Totic <atotic@chromium.org>' wrote:

[TablesNG] Fix rowspan cell height distribution over percentage rows

Bug: when rowspanned cell distributed its height over rows that were
all percentage sized, no height would be distributed.

The problem was that when percentage resolution block size is indefinite,
percentage rows were not treated as percentage rows.
They were also not treated as empty rows either.

Solution: treat percentage rows as empty rows when percentage resolutions
size is indefinite.

Bug: 1237879
Change-Id: I775b5ee5a0bdd7b8ec90f23d49642a3ba90a468b
Reviewed-on: https://chromium-review.googlesource.com/3088159
WPT-Export-Revision: a051253330345c77a6ad5886e4b3331846138603

Component: web-platform-tests → Layout: Tables
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 24 subtests

Status Summary

Firefox

OK : 1
PASS: 19[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 20[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub]
FAIL: 4[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub] 5[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]

Chrome

OK : 1
PASS: 23
FAIL: 1

Safari

OK : 1
PASS: 9
FAIL: 15

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-tables/tentative/rowspan-height-redistribution.html
table 18: FAIL linked bug:Bug 1705663
table 20: FAIL linked bug:Bug 1705663

New Tests That Don't Pass

/css/css-tables/tentative/rowspan-height-redistribution.html
table 7: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub] (Chrome: PASS, Safari: FAIL)
table 8: FAIL (Chrome: PASS, Safari: FAIL)
table 10: FAIL (Chrome: PASS, Safari: FAIL)
table 18: FAIL (Chrome: PASS, Safari: PASS)
table 20: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c90f6db1931
[wpt PR 29982] - [TablesNG] Fix rowspan cell height distribution over percentage rows, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8c90f6db1931

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.