Closed Bug 1725225 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29998 - Break floats inside self-collapsing blocks correctly.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29998 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29998
Details from upstream follow.

b'Morten Stenshorne <mstensho@chromium.org>' wrote:

Break floats inside self-collapsing blocks correctly.

Even if the BFC block-offset is unknown when finishing layout of a block
(this can happen if the block is self-collapsing), we still need to
FinalizeForFragmentation(), in order to detect any breaks inside child
floats, so that the break gets propagated correctly. If the initial
optimistic BFC block-offset guess was correct, we won't lay out again
with a forced block-offset identical to the optimistic one. So this is
our only chance.

Just use the optimistic block-offset if there's no BFC block-offset set.

Among the new tests, only float-in-self-collapsing-block-000.html were
failing without this, but I also added another test to verify that we
don't get stuck with an incorrect optimistic guess.

Bug: 1238508
Change-Id: Id70a4fc9a897ade0801dc1993742d2ba14209ad5
Reviewed-on: https://chromium-review.googlesource.com/3087457
WPT-Export-Revision: 7c3b7864d2d697d28a7dbaea2be8452b9360c235

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 2

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1fbbe058293d
[wpt PR 29998] - Break floats inside self-collapsing blocks correctly., a=testonly

https://hg.mozilla.org/mozilla-central/rev/1fbbe058293d

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.