Closed Bug 1725268 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 30000 - Revert "Highlight API: Invalidate Highlights before paint"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30000 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30000
Details from upstream follow.

b'Dirk Pranke <dpranke@google.com>' wrote:

Revert "Highlight API: Invalidate Highlights before paint"

This reverts commit bfbb399eeefa685d8266d56aaee30e96ea6c83f2.

Reason for revert: Reverting due to failures on the tree; see crbug.com/1238845

Original change's description:

Highlight API: Invalidate Highlights before paint

  • Move ValidateHighlightMarkers() call in paint phase to before
    calling PaintTree().

By rebuilding HighlightMarkers in paint phase after PaintTree()
there was invalidation that would be repainted in the next frame
paint, which wasn't being triggered unless there was some external
interaction or DOM manipulation.

Change-Id: I042913b823141f2b4c15c0206f227a6b623a4d35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3082151
Commit-Queue: Fernando Fiori \<ffiori@microsoft.com>
Reviewed-by: Dan Clark \<daniec@microsoft.com>
Reviewed-by: Stefan Zager \<szager@chromium.org>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Reviewed-by: Daniel Libby \<dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#910456}

Change-Id: I445095a3edea2705f270917fb4113a39846a52ea

Reviewed-on: https://chromium-review.googlesource.com/3089454
WPT-Export-Revision: 8d843e9f082b92c1eded84398a9844b51c907c0f

PR 30000 applied with additional changes from upstream: 0f94ca65282ba94a40f7d28f704a90aa5dce93e5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.