1725293 - checkValidity() on <select required> returns true when <option value=""> is moved in the dom

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[oyejorge]

Attachment: Screenshot 2021-08-11 at 19-46-16 JSFiddle - Code Playground.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

https://jsfiddle.net/qp4coed8/

<select required>.prepend( <option value=""> )

Actual results:

<select required>.checkValidity() returns true

Expected results:

<select required>.checkValidity() should return false

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1725293 - checkValidity() on <select required> returns true when <option value=> is moved in the dom, r=edgar

The new check should be still fast, since accessing selected index is trivial and Item() call is just accessing the element from an
nsTArray.

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/30148 for changes under testing/web-platform/tests

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5d85665d2784

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot