Closed Bug 1725350 Opened 3 years ago Closed 3 years ago

Test helper to ignore grid updates rejections on reflow

Categories

(DevTools :: Inspector, task)

task

Tracking

(Fission Milestone:MVP, firefox93 fixed)

RESOLVED FIXED
93 Branch
Fission Milestone MVP
Tracking Status
firefox93 --- fixed

People

(Reporter: bomsy, Assigned: bomsy)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(1 file)

There a certain situations where grid updates are triggered by reflows. These have in certain unexpected situations caused intermittents. A solution used in some tests are to turn off listening to reflow events See https://searchfox.org/mozilla-central/rev/3a8091d1c29473a0839ad7a5810028f41363fe2e/devtools/client/inspector/grids/test/browser_grids_grid-outline-highlight-area.js#40

As this is likely needed in more tests, lets provide a shared helper and possibly a better way to handle it

Suggestion from slack discussions

function disableGridPanelUpdateOnReflow() {
  const { PromiseTestUtils } = ChromeUtils.import(
    "resource://testing-common/PromiseTestUtils.jsm"
  );
  const removeRejectionException = PromiseTestUtils.allowMatchingRejectionsGlobally("getGrids);
  registerCleanupFunction(removeRejectionException);
}
Assignee: nobody → hmanilla
Attachment #9236006 - Attachment description: Bug 1725350 - [devtools] Add test helper to stop grid panel updates on reflow → Bug 1725350 - [devtools] Add test helper to stop grid panel updates on reflow r=nchevobbe
Status: NEW → ASSIGNED
Summary: Test helper to stop grid panel updates on reflow → Test helper to ignore grid updates rejections on reflow
Blocks: 1725565
No longer blocks: 1725565
See Also: → 1725565
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e68ab5359b8
[devtools] Add test helper to stop grid panel updates on reflow r=nchevobbe
Fission Milestone: --- → MVP
Whiteboard: dt-fission-m3-mvp
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: