1725363 - Replace PL_strcasecmp with nsCRT::strcasecmp

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Nicklas Boman [:smurfd]]

We should replace NSPR functions with standard C functions when they are available on all platforms, or in this case a wrapper since a standard C function is not available on all platforms.

Following work done in this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1308104 and some others like that, i filed this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1724649 that needed more work before being possible

Lets :

1. Replace PL_strcasecmp() calls with nsCRT::strcasecmp() outside of nsprpub/ and security/ code
   https://searchfox.org/mozilla-central/search?case=true&q=PL_strcasecmp

2. Add #include "nsCRT.h" if it's needed for nsCRT::strcasecmp()'s function declaration.

3. Remove #include "plstr.h" if it's no longer needed for other NSPR string function declarations.

Comment 1

[Nicklas Boman [:smurfd]]

Attachment: Bug 1725363 - Replace PL_strcasecmp with nsCRT::strcasecmp r=jrmuizel

Comment 2

[Nicklas Boman [:smurfd]]

Attachment: Bug 1725363 - Replace PL_strcasecmp with nsCRT::strcasecmp image/ r=aosmond

Comment 3

[Nicklas Boman [:smurfd]]

Attachment: Bug 1725363 - Replace PL_strcasecmp with nsCRT::strcasecmp layout/ r=tnikkel

Comment 4

[Nicklas Boman [:smurfd]]

Attachment: Bug 1725363 - Replace PL_strcasecmp with nsCRT::strcasecmp modules/libjar/ r=kershaw

Comment 5

[Nicklas Boman [:smurfd]]

Hey, will skip this part for now, will instead file a specific bug to replace all possible PL_ in nsCRT.h

It could probably be ok to change the nsCRT implementation to use the standard C function instead of the PL_
https://searchfox.org/mozilla-central/rev/f71cb98fc35da418d2cb9ce31a0416d532dc9d69/xpcom/ds/nsCRT.h#43-53

i see there was a warning in layout/base/PresShell.cpp but the line where i did the changes is allright.
It could be that i was not up-to-date with the tree. updated yesterday.

Let me know if there is questions :)

Comment 6

[Nicklas Boman [:smurfd]]

edited....

Comment 7

[Nicklas Boman [:smurfd]]

Im thinking this should still be ok to land...

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb288627e25c
Replace PL_strcasecmp with nsCRT::strcasecmp modules/libjar/ r=valentin

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5794d191c27
Replace PL_strcasecmp with nsCRT::strcasecmp image/ r=aosmond

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0877f8a8fac
Replace PL_strcasecmp with nsCRT::strcasecmp r=jrmuizel

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c568a569c161
Replace PL_strcasecmp with nsCRT::strcasecmp layout/ r=tnikkel

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/eb288627e25c
https://hg.mozilla.org/mozilla-central/rev/b5794d191c27
https://hg.mozilla.org/mozilla-central/rev/d0877f8a8fac
https://hg.mozilla.org/mozilla-central/rev/c568a569c161