Closed Bug 1725400 Opened 9 months ago Closed 9 months ago

Permanent Android bustage make[3]: *** [Makefile:150: recurse_android-archive-geckoview] Error 1 | Invalid publication 'withGeckoBinariesDebug': artifactId is not a valid Maven identifier ([A-Za-z0-9_\-.]+). when Gecko 92 merges to Release on 2021-08-30

Categories

(GeckoView :: General, defect, P1)

Unspecified
All

Tracking

(firefox-esr78 unaffected, firefox-esr91 unaffected, firefox91 unaffected, firefox92blocking verified, firefox93+ fixed)

VERIFIED FIXED
93 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox91 --- unaffected
firefox92 blocking verified
firefox93 + fixed

People

(Reporter: aryx, Assigned: agi)

Details

Attachments

(1 file)

[task 2021-08-12T11:21:52.086Z] 11:21:52     INFO -  Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf-8
[task 2021-08-12T11:21:52.086Z] 11:21:52     INFO -  > Task :geckoview:javadocJarWithGeckoBinariesDebug
[task 2021-08-12T11:21:52.086Z] 11:21:52     INFO -  > Task :geckoview:sourcesJarWithGeckoBinariesDebug
[task 2021-08-12T11:21:52.086Z] 11:21:52     INFO -  > Task :geckoview:publishWithGeckoBinariesDebugPublicationToMavenRepository FAILED
[task 2021-08-12T11:21:52.086Z] 11:21:52     INFO -  FAILURE: Build failed with an exception.
[task 2021-08-12T11:21:52.086Z] 11:21:52     INFO -  * What went wrong:
[task 2021-08-12T11:21:52.086Z] 11:21:52     INFO -  Execution failed for task ':geckoview:publishWithGeckoBinariesDebugPublicationToMavenRepository'.
[task 2021-08-12T11:21:52.087Z] 11:21:52     INFO -  > Failed to publish publication 'withGeckoBinariesDebug' to repository 'maven'
[task 2021-08-12T11:21:52.087Z] 11:21:52     INFO -     > Invalid publication 'withGeckoBinariesDebug': artifactId is not a valid Maven identifier ([A-Za-z0-9_\-.]+).
[task 2021-08-12T11:21:52.087Z] 11:21:52     INFO -  * Try:
[task 2021-08-12T11:21:52.087Z] 11:21:52     INFO -  Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
[task 2021-08-12T11:21:52.087Z] 11:21:52     INFO -  * Get more help at https://help.gradle.org
[task 2021-08-12T11:21:52.087Z] 11:21:52     INFO -  Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
[task 2021-08-12T11:21:52.087Z] 11:21:52     INFO -  Use '--warning-mode all' to show the individual deprecation warnings.
[task 2021-08-12T11:21:52.087Z] 11:21:52     INFO -  See https://docs.gradle.org/5.1.1/userguide/command_line_interface.html#sec:command_line_warnings
[task 2021-08-12T11:21:52.087Z] 11:21:52     INFO -  BUILD FAILED in 1m 16s

Agi, please investigate what's causing the failure. Could it be from the split into Android and Android Lite builds in bug 1709640?

Flags: needinfo?(agi)
Severity: -- → S1
Priority: -- → P1
Assignee: nobody → agi
Flags: needinfo?(agi)

The problem here is that the release artifactId was using single quotes instead
of double. I rewrote this code a little bit to avoid this sort of problem next
time by not having a release-build-only conditional branch.

Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0acb95460aa
Fix GeckoView release artifactId. r=nalexander,owlish

Comment on attachment 9236015 [details]
Bug 1725400 - Fix GeckoView release artifactId.

Beta/Release Uplift Approval Request

  • User impact if declined: Release builds of GeckoView won't build
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This change only affects the build artifact ID which is either correct or breaks the Fenix build altogether. The simulation try is green.
  • String changes made/needed:
Attachment #9236015 - Flags: approval-mozilla-beta?
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

Comment on attachment 9236015 [details]
Bug 1725400 - Fix GeckoView release artifactId.

Approved for Fenix 92.0.0-beta.4.

Attachment #9236015 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.