Closed Bug 1725426 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30008 - Update lifecycle to clean from popup.open

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30008 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30008
Details from upstream follow.

b'Mason Freed <masonf@chromium.org>' wrote:

Update lifecycle to clean from popup.open

There is a resize observer used by \<popup> to detect when it has
been resized, which is one of the "light-dismiss" conditions.
Because resize observer always fires once on the first Paint,
there was a case where the behavior from JS was confusing/
incorrect. Essentially, if you open the popup and then
immediately (synchronously) change the size of the popup, it
would not close. With this change, popup.open() forces a
rendering lifecycle.

This CL also splits out the resize tests for popup into a
separate file, and removes the usage of setTimeout(), which was
previously buttering over this bug. Thanks to wanming.lin@ for
pointing this out in [1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/3084482

Bug: 1197633

Change-Id: I733f1215799980d0ed922cf8d8d312cbdcc140b3

Reviewed-on: https://chromium-review.googlesource.com/3089750
WPT-Export-Revision: 7d8af24c5957aa1ed6d8c4ebbed4a787ed8497cd

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 9 subtests

Status Summary

Firefox

TIMEOUT: 1
ERROR : 2
NOTRUN : 1

Chrome

OK : 1
PASS : 8
FAIL : 1
TIMEOUT: 2
NOTRUN : 1

Safari

TIMEOUT: 1
ERROR : 2
NOTRUN : 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/interactive-elements/the-popup-element/popup-light-dismiss-resize.tentative.html: ERROR (Chrome: TIMEOUT, Safari: ERROR)
Popup should be closed by an explicit resize of the popup: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
Popup should be closed by an implicit resize of the popup: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
/html/semantics/interactive-elements/the-popup-element/popup-light-dismiss.tentative.html: ERROR (Chrome: OK, Safari: ERROR)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f575ab9c2043
[wpt PR 30008] - Update lifecycle to clean from popup.open, a=testonly
https://hg.mozilla.org/integration/autoland/rev/9e234247ff51
[wpt PR 30008] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f575ab9c2043
https://hg.mozilla.org/mozilla-central/rev/9e234247ff51

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.