1725430 - When screenshots.browser.component.enabled is true, the screenshots shortcut should bring up the new screenshots UI

Status: RESOLVED FIXED

(Firefox :: Screenshots, enhancement, P2)

Description

[Emma Malysz]

The screenshot shortcut (command+shift+s) currently brings up the extension screenshot UI when the pref is on. We'll need to make sure to honor the pref value.

Comment 1

[Emma Malysz]

Attachment: Bug 1725430: disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz!

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1725430: disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz!

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1725430: disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ceaaed353b66
disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz,fluent-reviewers,flod

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for assertion failure on ErrorResult.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/0793ce0be38e9a6341d884b08043ea8bb1dcfb85
Log link: https://treeherder.mozilla.org/logviewer?job_id=352287583&repo=autoland&lineNumber=1488

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec019c0205a9
disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz,fluent-reviewers,flod

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out changeset ec019c0205a9 (Bug 1725430) for causing failures on dbg-toggling-tools.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=LnhR32VYQ9S--8GPDG9kBw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=os%2Cx%2C10.15%2Cwebrender%2Copt%2Cmochitests%2Ctest-macosx1015-64-qr%2Fopt-mochitest-devtools-chrome-e10s%2Cdt5&revision=ec019c0205a9c801c20950096bd1de4a54155c7c

Log: https://treeherder.mozilla.org/logviewer?job_id=352864922&repo=autoland&lineNumber=4322

Backout: https://hg.mozilla.org/integration/autoland/rev/7b4e73e86e75bdefb52390f6d3074b011ad94982

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf09700f887a
disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz,fluent-reviewers,flod

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/cf09700f887a