Closed
Bug 1725430
Opened 4 years ago
Closed 4 years ago
When screenshots.browser.component.enabled is true, the screenshots shortcut should bring up the new screenshots UI
Categories
(Firefox :: Screenshots, enhancement, P2)
Firefox
Screenshots
Tracking
()
RESOLVED
FIXED
94 Branch
Tracking | Status | |
---|---|---|
firefox94 | --- | fixed |
People
(Reporter: emmamalysz, Assigned: niklas)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
The screenshot shortcut (command+shift+s) currently brings up the extension screenshot UI when the pref is on. We'll need to make sure to honor the pref value.
Reporter | ||
Updated•4 years ago
|
Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Reporter | ||
Updated•4 years ago
|
Assignee: emalysz → nbaumgardner
Reporter | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Attachment #9242097 -
Attachment is obsolete: true
Assignee | ||
Comment 3•4 years ago
|
||
Updated•4 years ago
|
Attachment #9241604 -
Attachment description: WIP: Bug 1725430: disable screenshot shortcut for extension when screenshots.browser.component.enabled is true → Bug 1725430: disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz!
Updated•4 years ago
|
Attachment #9242098 -
Attachment is obsolete: true
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ceaaed353b66
disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz,fluent-reviewers,flod
Comment 5•4 years ago
|
||
Backed out for assertion failure on ErrorResult.h
Backout link: https://hg.mozilla.org/integration/autoland/rev/0793ce0be38e9a6341d884b08043ea8bb1dcfb85
Log link: https://treeherder.mozilla.org/logviewer?job_id=352287583&repo=autoland&lineNumber=1488
Flags: needinfo?(nbaumgardner)
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec019c0205a9
disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz,fluent-reviewers,flod
Comment 7•4 years ago
|
||
Backed out changeset ec019c0205a9 (Bug 1725430) for causing failures on dbg-toggling-tools.js
Log: https://treeherder.mozilla.org/logviewer?job_id=352864922&repo=autoland&lineNumber=4322
Backout: https://hg.mozilla.org/integration/autoland/rev/7b4e73e86e75bdefb52390f6d3074b011ad94982
Flags: needinfo?(emalysz)
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf09700f887a
disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz,fluent-reviewers,flod
Comment 9•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Assignee | ||
Updated•4 years ago
|
Flags: needinfo?(nbaumgardner)
Reporter | ||
Updated•4 years ago
|
Flags: needinfo?(emalysz)
You need to log in
before you can comment on or make changes to this bug.
Description
•