Closed Bug 1725517 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30015 - Reject appHistory.goTo() promises on frame detach.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox93 fixed)

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30015 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30015
Details from upstream follow.

b'Nate Chapin <japhet@chromium.org>' wrote:

Reject appHistory.goTo() promises on frame detach.

This allows us to pass
external/wpt/app-history/navigate/goTo-detach-in-onnavigate.html,
which was timing out before.

Bug: 1219750
Change-Id: I104a473f847d67c9251af18609bb8626ee594eb2
Reviewed-on: https://chromium-review.googlesource.com/3089789
WPT-Export-Revision: ab3c7bf20772ab4c460959a819aa8648230a0b24

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 1 subtests

Status Summary

Firefox

OK : 5
FAIL : 5

Chrome

OK : 4
FAIL : 4
TIMEOUT: 2

Safari

OK : 5
FAIL : 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/app-history/navigate/goTo-detach-in-onnavigate.html
goTo() in a detached window: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/app-history/navigate-event/navigateerror-ordering-cross-document.html
navigateerror ordering when navigate() is called repeatedly (cross-document): FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigateerror-ordering-respondWith-reentrant.html
navigateerror ordering when navigate() is called reentrantly and handled by respondWith(): FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigateerror-ordering-respondWith.html
navigateerror ordering when navigate() is called repeatedly and handled by respondWith(): FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/signal-abort-window-stop-after-respondWith.html
window.stop() cancels AppHistoryNavigateEvent.respondWith and signals AppHistoryNavigateEvent.signal: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb5eedaf97c6
[wpt PR 30015] - Store both a ScriptPromise and ScriptPromiseResolver on OngoingNavigation, a=testonly
https://hg.mozilla.org/integration/autoland/rev/758b5d618c44
[wpt PR 30015] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/bb5eedaf97c6
https://hg.mozilla.org/mozilla-central/rev/758b5d618c44

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.