Closed Bug 1725537 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 30018 - Implement contain-intrinsic-size as a shorthand

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30018 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30018
Details from upstream follow.

b'Christian Biesinger <cbiesinger@chromium.org>' wrote:

Implement contain-intrinsic-size as a shorthand

Also adds logical versions of the property.

In effect, this adds support for contain-intrinsic-width,
contain-intrinsic-height, contain-intrinsic-inline-size and
contain-intrinsic-block-size.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/gBka8QBN1ac

Bug: 1157844
Change-Id: I6af892cd505ad240a55ffa7646f59343d5d47f0d

Reviewed-on: https://chromium-review.googlesource.com/3093047
WPT-Export-Revision: e8dd3be392b320043f6d60db73d72a8df6e72247

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 19 subtests

Status Summary

Firefox

OK : 3
PASS: 28
FAIL: 34

Chrome

OK : 3
PASS: 35
FAIL: 27

Safari

OK : 3
PASS: 28
FAIL: 34

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-logical-001.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/contain-intrinsic-size/contain-intrinsic-size-logical-002.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/contain-intrinsic-size/parsing/contain-intrinsic-size-computed.html
Property contain-intrinsic-size value 'auto': FAIL (Chrome: PASS, Safari: FAIL)
Property contain-intrinsic-size value '1px': FAIL (Chrome: PASS, Safari: FAIL)
Property contain-intrinsic-size value '2vw 3px': FAIL (Chrome: FAIL, Safari: FAIL)
Property contain-intrinsic-size value '2px 3vh': FAIL (Chrome: FAIL, Safari: FAIL)
Property contain-intrinsic-size value '5px 5px': FAIL (Chrome: PASS, Safari: FAIL)
Property contain-intrinsic-width value 'auto': FAIL (Chrome: FAIL, Safari: FAIL)
Property contain-intrinsic-width value '1px': FAIL (Chrome: FAIL, Safari: FAIL)
Property contain-intrinsic-width value '2vw': FAIL (Chrome: FAIL, Safari: FAIL)
Property contain-intrinsic-width value '3vh': FAIL (Chrome: FAIL, Safari: FAIL)
Property contain-intrinsic-height value 'auto': FAIL (Chrome: FAIL, Safari: FAIL)
Property contain-intrinsic-height value '1px': FAIL (Chrome: FAIL, Safari: FAIL)
Property contain-intrinsic-height value '2vw': FAIL (Chrome: FAIL, Safari: FAIL)
Property contain-intrinsic-height value '3vh': FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/contain-intrinsic-size/parsing/contain-intrinsic-size-valid.html
e.style['contain-intrinsic-size'] = "auto" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
e.style['contain-intrinsic-size'] = "1px" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
e.style['contain-intrinsic-size'] = "2em 3px" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
e.style['contain-intrinsic-size'] = "5px 5px" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
e.style['contain-intrinsic-size'] = "auto auto" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['contain-intrinsic-size'] = "1px auto" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['contain-intrinsic-size'] = "auto 1px" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['contain-intrinsic-width'] = "auto" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['contain-intrinsic-width'] = "1px" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['contain-intrinsic-width'] = "2em" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['contain-intrinsic-height'] = "auto" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['contain-intrinsic-height'] = "1px" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['contain-intrinsic-height'] = "2em" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['contain-intrinsic-inline-size'] = "auto" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['contain-intrinsic-inline-size'] = "1px" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['contain-intrinsic-inline-size'] = "2em" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['contain-intrinsic-block-size'] = "auto" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['contain-intrinsic-block-size'] = "1px" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['contain-intrinsic-block-size'] = "2em" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e2da42cf5993 [wpt PR 30018] - Implement contain-intrinsic-size as a shorthand, a=testonly https://hg.mozilla.org/integration/autoland/rev/2548aedc6e70 [wpt PR 30018] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e2da42cf5993
https://hg.mozilla.org/mozilla-central/rev/2548aedc6e70

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.