Closed Bug 1725541 Opened 5 months ago Closed 4 months ago

Make test_layerization.html work on xorig runs

Categories

(Core :: Panning and Zooming, task, P2)

task

Tracking

()

RESOLVED FIXED
94 Branch
Fission Milestone Future
Tracking Status
firefox-esr78 --- wontfix
firefox-esr91 --- wontfix
firefox92 --- wontfix
firefox93 --- wontfix
firefox94 --- fixed

People

(Reporter: hiro, Assigned: tnikkel)

References

Details

Attachments

(1 file)

It still doesn't work with the changes for bug 1725540. The errors are mostly same as bug 1722907 comment 0;

In the xorigin case there's an additional error;

inner4 still is directly activated because it never expired

Hiro, does this test_layerization.html test fail in xorigin mode regardless of whether Fission is enabled or not? Do we need to fix this test for Fission?

Fission Milestone: --- → ?
Flags: needinfo?(hikezoe.birchill)

I just run it locally to make sure the situation. Actually the test also fails with disabling Fission, but in a different way. It causes a time out rather than the errors in comment 0.

Flags: needinfo?(hikezoe.birchill)
Assignee: nobody → tnikkel

Assigned to Tim. Linking to MVP for now. If found not urgent can push to future

Fission Milestone: ? → MVP
Whiteboard: fission-soft-blocker
Type: defect → task
Priority: -- → P2

This test is currently skipped on Android, headless Fission Linux, and xorigin mode:

https://searchfox.org/mozilla-central/rev/aa46c2dcccbc6fd4265edca05d3d00cccdfc97b9/gfx/layers/apz/test/mochitest/mochitest.ini#62-66

[test_layerization.html]
  skip-if =
    os == 'android'  # wheel events not supported on mobile
    os == 'linux' && fission && headless # Bug 1722907
    xorigin # "scrolling 'inner2' should cause it to be directly activated" etc.

Bug 1722907 is another test_layerization.html test failure.

See Also: → 1722907

Just to update after investigation I don't think there is a problem in the browser that we want to fix to make this test pass. There are some differences in the size of display ports that happen when we have process boundaries vs when we don't, and the test was unintentionally relying on having the sizes without process boundaries.

The test is run inside the usual mochitest iframe, meaning half of the content is not visible, and since displayports are based on what is visible, and the test checks against the a multiple of the full element height, the displayports height is not enough when we have a process boundary.

The fix would be one of the following:

  1. use a multiple of the visible element height to compare the displayport height against
  2. shrink the content so it fits in the mochitest iframe
  3. open the test in a new tab so the full content is visible, and maybe put it in an xorigin iframe in the new tab so we still test the xorigin case

Since there isn't a code fix here and only a test fix this doesn't really need to block mvp.

(In reply to Timothy Nikkel (:tnikkel) from comment #5)

Since there isn't a code fix here and only a test fix this doesn't really need to block mvp.

In that case, I'll move this bug to from Fission Milestone MVP to our Future backlog. Thanks for the explanation!

Fission Milestone: MVP → Future
Whiteboard: fission-soft-blocker
Pushed by hikezoe.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ece3dcc343a2
Consider that the test runs inside an iframe whose size is smaller than the target element's size. r=tnikkel
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch

Setting status-firefox93=wontfix because we don't need to uplift this test fix to Beta 93.

You need to log in before you can comment on or make changes to this bug.