1725568 - fetch-content issues with python >= 3.8

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Mike Hommey [:glandium]]

python 3.8 changed the default tar format it uses in tarfile, using PAX_FORMAT instead of GNU_FORMAT. That breaks some filtering cases where the initial archive contains long file names, which end up setting pax_headers["path"] (yes, even if the original wasn't PAX_FORMAT) that isn't filtered.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1725568 - Reformat fetch-content with black.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1725568 - When repacking use the same tar format as the original.

Not whatever happens to be the default in the tarfile module.
Also, apply filters to pax_headers["path"] when it's set.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02202f5f9e4d
Reformat fetch-content with black. r=taskgraph-reviewers,bhearsum
https://hg.mozilla.org/integration/autoland/rev/190e167d641a
When repacking use the same tar format as the original. r=taskgraph-reviewers,bhearsum

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/02202f5f9e4d
https://hg.mozilla.org/mozilla-central/rev/190e167d641a