Closed Bug 1725568 Opened 4 months ago Closed 4 months ago

fetch-content issues with python >= 3.8

Categories

(Firefox Build System :: Task Configuration, task)

task

Tracking

(firefox93 fixed)

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(2 files)

python 3.8 changed the default tar format it uses in tarfile, using PAX_FORMAT instead of GNU_FORMAT. That breaks some filtering cases where the initial archive contains long file names, which end up setting pax_headers["path"] (yes, even if the original wasn't PAX_FORMAT) that isn't filtered.

Not whatever happens to be the default in the tarfile module.
Also, apply filters to pax_headers["path"] when it's set.

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/02202f5f9e4d
Reformat fetch-content with black. r=taskgraph-reviewers,bhearsum
https://hg.mozilla.org/integration/autoland/rev/190e167d641a
When repacking use the same tar format as the original. r=taskgraph-reviewers,bhearsum
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.