1725615 - Replace OS.File with IOUtils in the crash reporter code

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, task)

Description

[Gabriele Svelto [:gsvelto]]

As per title, the affected files are the following (they're mostly tests):

• toolkit/components/crashes/tests/xpcshell/test_crash_service.js
• toolkit/components/crashes/CrashManagerTest.jsm
• toolkit/components/crashmonitor/test/unit/test_valid_file.js
• toolkit/components/crashmonitor/test/unit/test_invalid_json.js
• toolkit/components/crashmonitor/test/unit/test_invalid_file.js
• toolkit/crashreporter/CrashSubmit.jsm
• toolkit/crashreporter/content/crashes.js
• toolkit/crashreporter/test/unit/test_crash_exc_guard.js
• toolkit/crashreporter/test/unit/head_win64cfi.js
• toolkit/crashreporter/test/unit/head_crashreporter.js
• toolkit/crashreporter/test/unit/test_crash_modules.js
• toolkit/crashreporter/test/unit/test_crash_heap_corruption.js
• toolkit/crashreporter/test/unit/test_crash_AsyncShutdown.js

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1725615 - Port osfile.jsm usage to IOUtils in toolkit/components/crashes r?gsvelto

Comment 2

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1725615 - Port osfile.jsm usage to IOUtils in toolkit/components/crashmonitor r?gsvelto

Depends on D163055

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1725615 - Port osfile.jsm usage to IOUtils in toolkit/crashreporter/ r?gsvelto

Depends on D163056

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1625d713bf28
Port osfile.jsm usage to IOUtils in toolkit/components/crashes r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/0678f083099a
Port osfile.jsm usage to IOUtils in toolkit/components/crashmonitor r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/4a94ba555fc5
Port osfile.jsm usage to IOUtils in toolkit/crashreporter/ r=gsvelto

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on browser_clearReports.js

• backout: https://hg.mozilla.org/integration/autoland/rev/a0ce2796305c4c39781dcc873eae92e530ddab89
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=4a94ba555fc58b4234df08c9fb31b639d944d5ec
• failure log: https://treeherder.mozilla.org/logviewer?job_id=398467545&repo=autoland&lineNumber=12197

[task 2022-12-02T15:44:14.024Z] 15:44:14     INFO - TEST-PASS | toolkit/crashreporter/test/browser/browser_clearReports.js | Submitted report list is visible - "block" != "none" - 
[task 2022-12-02T15:44:14.025Z] 15:44:14     INFO - Console message: [JavaScript Error: "NotFoundError: Could not stat file(/tmp/tmpouqgccli.mozrunner/UAppData/Crash Reports/InstallTimeOld) because it does not exist"]
[task 2022-12-02T15:44:14.027Z] 15:44:14     INFO - Buffered messages finished
[task 2022-12-02T15:44:14.027Z] 15:44:14     INFO - TEST-UNEXPECTED-FAIL | toolkit/crashreporter/test/browser/browser_clearReports.js | Uncaught exception in test - undefined - timed out after 50 tries.
[task 2022-12-02T15:44:14.027Z] 15:44:14     INFO - Leaving test bound test
[task 2022-12-02T15:44:14.028Z] 15:44:14     INFO - GECKO(7984) | cleanup_fake_appdir: dirSvc.undefine failed: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.undefine]
[task 2022-12-02T15:44:14.029Z] 15:44:14     INFO - GECKO(7984) | MEMORY STAT | vsize 11226MB | residentFast 447MB | heapAllocated 188MB
[task 2022-12-02T15:44:14.032Z] 15:44:14     INFO - TEST-OK | toolkit/crashreporter/test/browser/browser_clearReports.js | took 5584ms
[task 2022-12-02T15:44:14.033Z] 15:44:14     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-12-02T15:44:14.034Z] 15:44:14     INFO - TEST-UNEXPECTED-FAIL | toolkit/crashreporter/test/browser/browser_clearReports.js | Found an unexpected tab at the end of test run: about:crashes - 

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:barret, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 7

[Gabriele Svelto [:gsvelto]]

Barret do you have time to look into the failures and try to re-land this?

Comment 8

[Beth Rennie [:beth] (she/her)]

Yeah, this is in my backlog to fix soon.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be82dc9f684f
Port osfile.jsm usage to IOUtils in toolkit/components/crashes r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/aba8e190afdd
Port osfile.jsm usage to IOUtils in toolkit/components/crashmonitor r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/f1cdc5b4f15f
Port osfile.jsm usage to IOUtils in toolkit/crashreporter/ r=gsvelto

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/be82dc9f684f
https://hg.mozilla.org/mozilla-central/rev/aba8e190afdd
https://hg.mozilla.org/mozilla-central/rev/f1cdc5b4f15f