Closed Bug 1725663 Opened 4 months ago Closed 3 months ago

[wpt-sync] Sync PR 30022 - Remove DCHECK from LegacyFragmentToPaint().

Categories

(Core :: SVG, task, P4)

task

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30022 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30022
Details from upstream follow.

b'Morten Stenshorne <mstensho@chromium.org>' wrote:

Remove DCHECK from LegacyFragmentToPaint().

There's code that sets up PaintInfo objects on its own in
SVGObjectPainter, LayoutSVGResourceClipper and CanvasFormattedText,
without specifying a FragmentData ID. None of these should have to deal
with block fragmentation (SVGs and canvases are monolithic, i.e.
unbreakable), but with legacy block fragmentation, we may still create
multiple FragmentData entries for the same object here, if it is too
tall to fit in one whole fragmentainer.

An alternative fix would be to set the fragment ID to the first
FragmentData entry of the object at all these sites, but it doesn't make
much of a difference, and this won't be needed once the legacy engine is
gone, anyway.

Bug: 1238412
Change-Id: I22a8794105c6e106af5b267f34443d8c6ef80e8d
Reviewed-on: https://chromium-review.googlesource.com/3094268
WPT-Export-Revision: e76d523fb575df60f949e0e5af42a2e72e5fa45b

Component: web-platform-tests → SVG
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/75ddd380465a
[wpt PR 30022] - Remove DCHECK from LegacyFragmentToPaint()., a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.