Closed Bug 1725695 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30023 - Fix some NotAllowedError --> SecurityError cases for PaymentRequest.show()

Categories

(Core :: DOM: Web Payments, task, P4)

Product:
Core
Component:
DOM: Web Payments
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30023 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30023
Details from upstream follow.

b'Stephen McGruer <smcgruer@chromium.org>' wrote:

Fix some NotAllowedError --> SecurityError cases for PaymentRequest.show()

See https://github.com/w3c/payment-request/pull/961

Component: web-platform-tests → DOM: Web Payments
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
FAIL : 5

Chrome

OK : 1
FAIL : 4
TIMEOUT: 1

Safari

OK : 1
PASS : 1
FAIL : 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/payment-request/payment-request-show-method.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
Calling show() without being triggered by user interaction throws: FAIL (Chrome: TIMEOUT, Safari: PASS)
Throws if the promise [[state]] is not 'created'.: FAIL (Chrome: FAIL, Safari: FAIL)
If the user agent's "payment request is showing" boolean is true, then return a promise rejected with an "AbortError" DOMException.: FAIL (Chrome: FAIL, Safari: FAIL)
If payment method consultation produces no supported method of payment, then return a promise rejected with a "NotSupportedError" DOMException.: FAIL (Chrome: FAIL, Safari: FAIL)
Calling show() multiple times always returns a new promise.: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/payment-request/payment-request-show-method.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-qr-debug, Gecko-windows10-32-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61dcf8697495
[wpt PR 30023] - Fix some NotAllowedError --> SecurityError cases for PaymentRequest.show(), a=testonly

https://hg.mozilla.org/mozilla-central/rev/61dcf8697495

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.