1725806 - Implement autocorrect attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

From https://phabricator.services.mozilla.com/D118945

It would be nice to get that HTML autocorrect PR landed before we ship, but I don't see a problem enabling it on Nightly/early Beta. And we should send an intent to ship. Hope that helps!

WHATWG issue: https://github.com/whatwg/html/issues/3595
WHATWG PR: https://github.com/whatwg/html/pull/5841

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Ok, so the PR isn't in the spec yet.

Comment 3

[Makoto Kato [:m_kato]]

Simon, do you know current status of https://github.com/whatwg/html/pull/5841? I would like to support 'autocorrect' attribute for MacOS's "text replacement" feature. I don't know whether I have to wait until its PR is merged.

Comment 4

[Simon Pieters [:zcorpan]]

It seems to me it's ready to land (checkboxes are checked, spec PR and wpt PR are reviewed), modulo open discussion threads. I've pinged domenic and annevk in https://whatwg.org/chat

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

FWIW, the pr is on WHAT WG meeting agenda, so I guess it might get landed quite soon.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

makoto, do you think you could take a look at the pr and see if it looks ok to you, and report any issues in the pr?

Comment 7

[Makoto Kato [:m_kato]]

I will look it this week.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Thanks. Looks like the pr was updated
https://github.com/whatwg/html/pull/5841

Comment 9

[Simon Pieters [:zcorpan]]

https://github.com/whatwg/html/pull/5841 has been merged.

Comment 10

[Makoto Kato [:m_kato]]

Attachment: Bug 1725806 - Part 1. Add autocorrect attribute in html parser. r=#dom-core

Implement https://html.spec.whatwg.org/#autocorrection for HTML parser.

Comment 11

[Makoto Kato [:m_kato]]

Attachment: Bug 1725806 - Part 2. Implement autocorrect attribute. r=#dom-core!

Implement https://html.spec.whatwg.org/#autocorrection

Comment 12

[Makoto Kato [:m_kato]]

Attachment: Bug 1725806 - Part 3. Autocorrect support in InputContext. r=masayuki!

Add autocorrect flag to InputContext to handle this by widget.

Since autocorrect is on-by-default, mAutocorrect is true by constructor.

But, I would like off-by-default in Chrome. Since Chrome UI may not want to
enable autocorrect by default such as bug 1881783.

Comment 13

[Makoto Kato [:m_kato]]

Attachment: Bug 1725806 - Part 4. Support autocorrect on macOS backend. r=masayuki!

If autocorrect is turned on (this is default), we turn on text replacement.

And, autocorrect attribute is on-by-default, and it is different for
spellcheck, so I would like to remove ui.autocorrectDefault preference.

Comment 14

[Makoto Kato [:m_kato]]

Attachment: Bug 1725806 - Part 5. Support autocorrect on GeckoView backend. r=#geckoview-reviewers!

Comment 15

[Makoto Kato [:m_kato]]

Attachment: Bug 1725806 - Part 6. Support autocorrect on UIKit backend. r=masayuki!

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/312b21ee0a22
Part 1. Add autocorrect attribute in html parser. r=dom-core,hsivonen
https://hg.mozilla.org/integration/autoland/rev/4eadad314e19
Part 2. Implement autocorrect attribute. r=dom-core,webidl,saschanaz,hsivonen
https://hg.mozilla.org/integration/autoland/rev/ddef034c455e
Part 3. Autocorrect support in InputContext. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/ab6098fafbbd
Part 4. Support autocorrect on macOS backend. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/cdf733bf2fb2
Part 5. Support autocorrect on GeckoView backend. r=geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/b98daff2809a
Part 6. Support autocorrect on UIKit backend. r=masayuki

Comment 17

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/312b21ee0a22
https://hg.mozilla.org/mozilla-central/rev/4eadad314e19
https://hg.mozilla.org/mozilla-central/rev/ddef034c455e
https://hg.mozilla.org/mozilla-central/rev/ab6098fafbbd
https://hg.mozilla.org/mozilla-central/rev/cdf733bf2fb2
https://hg.mozilla.org/mozilla-central/rev/b98daff2809a

Comment 18

[Henri Sivonen (:hsivonen)]

https://github.com/validator/htmlparser/commit/c25f974c4fc60499e25a32a414da58407e8787af

Comment 19

[Hamish Willee]

FF134 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/36919

I just tried this on the FF134 nightly build - checking dom.forms.autocorrect is indeed enabled. The MDN autocorrect example code shows when the property is defined but does not appear to autocorrect (i.e. if I enter "carot" in the vegetable box I expect it to correct).
Note that this code does work on Safari, which while not fully compliant with the spec should work in the same way for attribute being set like this.

1. Is the implementation complete? If not, what is missing
2. Is there anything else special I have to do to get this to work?

Comment 20

[Makoto Kato [:m_kato]]

(In reply to Hamish Willee from comment #19)

FF134 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/36919

I just tried this on the FF134 nightly build - checking dom.forms.autocorrect is indeed enabled. The MDN autocorrect example code shows when the property is defined but does not appear to autocorrect (i.e. if I enter "carot" in the vegetable box I expect it to correct).
Note that this code does work on Safari, which while not fully compliant with the spec should work in the same way for attribute being set like this.

1. Is the implementation complete? If not, what is missing

Although I don't know who write this sample, this autocorrect doesn't fix a word automatically. If using Firefox/macOS, you have to register the word in text substitution (see https://support.apple.com/en-vn/guide/mac-help/mh35735/mac). If Fenix, it depends on virtual keyboard implementation (Gecko only gives a hint to keyboard.)

Comment 21

[Hamish Willee]

I wrote that sample - it worked on Safari on macOS on browserstack. Thanks for the answer though. It indicates something I may not have captured sufficiently in the docs - that this enables autocorrection using native methods - and those methods may have other requirements.

Comment 22

[Hamish Willee]

Note, though, I'm still a bit unconvinced of this in Windows desktop. If I enable autocorrection and incorrect-text on the device (Settings > Devices> Typing) and try the sample then the word carot is highlighted as an error - i.e. the system knows this is incorrect. However it is not autocorrected on the input where autocorrection is enabled.

Comment 23

[Makoto Kato [:m_kato]]

(In reply to Hamish Willee from comment #22)

Note, though, I'm still a bit unconvinced of this in Windows desktop. If I enable autocorrection and incorrect-text on the device (Settings > Devices> Typing) and try the sample then the word carot is highlighted as an error - i.e. the system knows this is incorrect. However it is not autocorrected on the input where autocorrection is enabled.

There is no API to provide a hint whether autocorrect or not on Windows. Each software keyboard type seems to have the register value whether showing autocorrect widget.