Downloads panel is unnecessarily large when there are no downloads
Categories
(Firefox :: Downloads Panel, enhancement)
Tracking
()
People
(Reporter: aoia7rz7l, Unassigned)
Details
Tested on 92.0b3 and and 93.0a1(2021-08-13) BuildID 20210813215247 but I think this has been an issue since 89 when proton is enabled.
STR:
- Right click anywhere on the toolbar and select Customize/ Customize Toolbar.
- Right click on the Downloads browserAction button and deselect Auto-Hide in Toolbar/ Hide Button When Empty.
- Exit Customize/ Customize Toolbar.
- Click on the Downloads browserAction button.
- Downloads panel should read "No downloads for this session.".
Expected Behavior:
Downloads panel resizes dynamically and does not obstruct more screen estate than is necessary (see ESR78).
Actual Behavior:
Downloads panel contains large empty spaces to the right of "No downloads for this session" text when there are no downloads.
|
||
Updated•4 years ago
|
|
||
Comment 1•4 years ago
|
||
(In reply to aoia7rz7l from comment #0)
Downloads panel resizes dynamically and does not obstruct more screen estate than is necessary (see ESR78).
I don't understand, why does this matter? You can trivially close the panel when you've read the message, and if there are no downloads there is also no reason to keep the panel open, I would have thought?
(In reply to :Gijs (he/him) from comment #1)
I don't understand, why does this matter? You can trivially close the panel when you've read the message, and if there are no downloads there is also no reason to keep the panel open, I would have thought?
Not sure if I understood this correctly, but I don't see why the triviality is relevant here. By this argument, the download panel could have obstructed half the screen when empty and it would still be trivial to close the panel – simply click anywhere outside the panel. Better yet, you could still dismiss it "trivially" by hitting the Esc key even if the download panel (hypothetically) obstructed the entire screen!
I did a quick check and it would seem like the text was introduced some time during Australis. Prior to that the panel simply showed the "Show All Downloads" button when empty. Right now in Proton there is so much empty space in the download panel I could fit another sentence of "No downloads for this session." immediately after the text. I am going to guess that the panel width is now fixed for some reason and the empty spaces were simply a side effect of that?
Feel free to close the issue if this is another case of "yes this is according to proton spec", but I didn't manage to find any public spec or user story for this on Bugzilla.
|
|
||
Comment 3•4 years ago
|
||
(In reply to aoia7rz7l from comment #2)
(In reply to :Gijs (he/him) from comment #1)
I don't understand, why does this matter? You can trivially close the panel when you've read the message, and if there are no downloads there is also no reason to keep the panel open, I would have thought?
Not sure if I understood this correctly, but I don't see why the triviality is relevant here.
Because we have to choose what to work on, and a big factor in making that decision is understanding "how severe/serious is this problem". So I asked why it mattered for precisely that reason - sometimes things that don't matter to one person matter enormously to someone else (for reasons other than aesthetics) and that isn't obvious.
Feel free to close the issue if this is another case of "yes this is according to proton spec", but I didn't manage to find any public spec or user story for this on Bugzilla.
I checked the spec and yes, this appears to be intentional. The panel is expected to be the same width as when it does have downloads.
Description
•