1725820 - Crash in [@ AsyncShutdownTimeout | Places Clients shutdown | sanitize.js: Sanitize,sanitize.js: Sanitize on shutdown]

Status: NEW

(Toolkit :: Places, defect, P3)

Description

[Asif Youssuff]

Crash report: https://crash-stats.mozilla.org/report/index/8fc1f38d-6e7a-4e75-ab28-e0b420210813

MOZ_CRASH Reason: MOZ_CRASH()

Top 10 frames of crashing thread:

0 firefox mozalloc_abort /build/firefox/src/firefox-91.0/memory/mozalloc/mozalloc_abort.cpp:33
1 libxul.so NS_DebugBreak /build/firefox/src/firefox-91.0/xpcom/base/nsDebugImpl.cpp:435
2 libxul.so nsDebugImpl::Abort /build/firefox/src/firefox-91.0/xpcom/base/nsDebugImpl.cpp:134
3 libxul.so NS_InvokeByIndex 
4 libxul.so XPCWrappedNative::CallMethod /build/firefox/src/firefox-91.0/js/xpconnect/src/XPCWrappedNative.cpp:1143
5 libxul.so XPC_WN_CallMethod /build/firefox/src/firefox-91.0/js/xpconnect/src/XPCWrappedNativeJSOps.cpp:922
6 libxul.so js::InternalCallOrConstruct /build/firefox/src/firefox-91.0/js/src/vm/Interpreter.cpp:511
7 libxul.so Interpret /build/firefox/src/firefox-91.0/js/src/vm/Interpreter.cpp:3226
8 libxul.so js::Call /build/firefox/src/firefox-91.0/js/src/vm/Interpreter.cpp:588
9 libxul.so PromiseReactionJob /build/firefox/src/firefox-91.0/js/src/builtin/Promise.cpp:1905

From https://old.reddit.com/r/firefox/comments/p1oq6p/im_switching_to_esr_now_that_91_is_coming_out/h8te0gg/?context=3

127 crashes in the last week.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Places' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Ignoring the formData: blocking and offlineApps: blocking metadata cases that are handled in other reports, we still have a few cases of history: blocking here, that means history taking too long to be cleaned up.

Now one concern I have here is that history cleaner is made up of 2 parts and we don't know which of the 2 we are awaiting for, so I'd like to add more logging here
https://searchfox.org/mozilla-central/rev/5a49163b7012ded5fa1c4da5aa4f8d3f7c85a5e7/browser/modules/Sanitizer.sys.mjs#410,424-425

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

There's 2 main steps blocked in history clearing:

• await gPrincipalsCollector.getAllPrincipals(progress);
• await new Promise(resolve => { Services.clearData.deleteUserInteractionForClearingHistory(...

Both are more related to principals, than history itself.

There has been an apparent increase of crashes starting in September, according to the global graph above.
I think the getAllPrincipals hang is already known (though I can't find anymore the bug tracking that).
The second case seems interesting as deleteUserInteractionForClearingHistory doesn't seem to ever invoke the callback in case of errors, so it's easy for the promise to never resolve.
I'll file a bug for handling rejections there.