1725837 - string length is too short in download panel and download speed is almost always truncated (in e.g. French and potentially other locales)

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P2)

Description

[[e-mail]]

Attachment: 1.png

• download a file big enough so you have to wait for it to complete
• check your download panel
• depends on duration, file size, and probably user locale too, but in french 9/10 chances that you can't read the download speed (cf. attachment 1 [details] [diff] [review])

If find it very annoying, especially when I see this huge unused space just after.
How could this pass quality check, nobody download big legal video files in here?

Comment 1

[[e-mail]]

(Ignore cf link, it wasn't intended)

Comment 2

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Attachment: download.jpg

Hi,
Thank you for taking the time to submit this bug report. I was able to reproduce on windows 10 pro using https://www.thinkbroadband.com/download on the following versions, using

latest Firefox Nightly 93.0a1 (2021-08-17) (64-bit)
Release 91.0.1 (64-bit) as well as latest beta.

A component has been set in order to get the dev team involved. I'll provide a reg range asap
Best regards,
Clara

Comment 3

[Cristian Baica [:cbaica], Release Desktop QA]

Please note that this issue is also encountered with RTL locale builds (e.g. persian, arabic, hebrew).

Comment 4

[:Gijs (he/him)]

Although the changes in bug 1715001 will help by reducing the gap between the close button and the text and progress bar, I've noticed two other issues:

• the French localization specifies a width of 70ch at:

https://searchfox.org/l10n/rev/73ccd4b37acaafe3e8273515d86689cb18f5ed35/fr/browser/browser/downloads.ftl#19-20

This is the same as English, but the French translation is significantly longer ("Temps restant: ..." vs "... left").

• Since bug 1699552 we override the width for all localizations anyway. This is a regression.

Emma or Mike, do you have cycles to look at this? It's not really clear to me what we should do, but my best guess is removing the localized string and using a new one, which we default to the 35em in English (and then remove the hardcoded style rule we have atm), giving other locales a chance to pick a different value.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1725837 - Adjust detail text size in Downloads Panel, and remove hardcoded width. r?emalysz!

Comment 6

[:Gijs (he/him)]

Setting severity to S2 given this doesn't affect all locales/OS combinations, some of it is addressed by other work, the information is not security-critical, and workarounds exist (e.g. checking in the library or about:downloads ).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c69fc87e9d8
Adjust detail text size in Downloads Panel, and remove hardcoded width. r=emalysz,fluent-reviewers,flod

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/3c69fc87e9d8

Comment 9

[Anca Soncutean, Desktop QA]

Reproduced with 93.0a1 (2021-08-14) on Windows 10 (fr locale).
Verified fixed with 94.0a1 (2021-09-13) and 93.0b4 on Windows 10, Ubuntu 18.04 and macOS 11.0.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider uplifting to ESR91? I think we'd need to bump l10n-changesets.json also if we did?

Comment 11

[Francesco Lodolo [:flod]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #10)

I think we'd need to bump l10n-changesets.json also if we did?

Indeed, we would need to.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

(In reply to Francesco Lodolo [:flod] from comment #11)

Indeed, we would need to.

Does that disqualify it from an ESR uplift?

Comment 13

[Ryan VanderMeulen [:RyanVM]]

No, it's just an extra step to be mindful of if do.

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9239009 [details]
Bug 1725837 - Adjust detail text size in Downloads Panel, and remove hardcoded width. r?emalysz!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This makes it easier for users on non en-US locales to see more information about ongoing downloads.
• User impact if declined: Certain locales will find that the downloads panel is too narrow to display enough information about ongoing or completed downloads.
• Fix Landed on Version: 93
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is mainly a style-only patch, and it's been out in the wild now on the release channel for over a month, so this should be fairly safe to take, presuming it applies cleanly.
• String or UUID changes made by this patch: downloads-panel-list.style was removed and replaced with downloads-panel-items.style.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9239009 [details]
Bug 1725837 - Adjust detail text size in Downloads Panel, and remove hardcoded width. r?emalysz!

Approved for 91.4esr. I included the Fx94 l10n-changesets.json from mozilla-release tip as well.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/fdead2dcc9ec

Comment 17

[Anca Soncutean, Desktop QA]

Verified fixed (ar and fr locales) with 91.4.0esr on Windows 10, Ubuntu 20.04 and macOS 11.0.