1725864 - Thunderbird v91 is borking add-on

Status: RESOLVED INVALID

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[williamzijl7]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

So, I'm trying to fix https://github.com/darkreader/darkreader/issues/6521, while at first it seemed like only some functions was somehow throwing up exceptions and simply could be disabled(setIcon), Dark reader still was throwing up some exceptions which I could debug due to thunderbird throwing up
Error while calling actor 'thread's method 'setBreakpoint' can't access dead object
InvisibleToDebugger: TypeError { } errors.

So

1. Get thunderbird v91.
2. Install dark reader(I'm not in a position to get a small reproduce-able test case).
3. See that the pop-up doesn't work(Fixed by disabling setIcon in the codehttps://github.com/darkreader/darkreader/pull/6522)
4. After that their are still errors about messaging and chrome.runtime.sendMessage
5. See that you cannot set breakpoints because thunderbird is throwing errors about it.

Actual results:

I was expecting for v91 not to break Dark Reader, but things can happen I understand that. The other thing is that I cannot properly debug a content script because it won't let me set breakpoints and their is zero to none errors about errors within the contentscript.

Expected results:

Darkreader should work with a few tweaks and exceptions to the newest version. And I'd expected to be able to set a breakpoint in the code and see what's going on and why it's not working.

Comment 1

[Mark Banner (:standard8)]

Note https://thunderbird.topicbox.com/groups/addons is a good place to follow-updates on latest happenings, and to get hints and tips for working on add-ons.

The content scripts should be able to be debugged via the developer toolbox.

In the Error Console you may need to enable "Show Content Messages" in the cog menu to display messages from content.

Comment 2

[williamzijl7]

Note https://thunderbird.topicbox.com/groups/addons is a good place to follow-updates on latest happenings, and to get hints and tips for working on add-ons.

Ah thanks, good resource to have look.

The content scripts should be able to be debugged via the developer toolbox.

Yes, that's correct. However currently thunderbird will error in the console.

Error while calling actor 'thread's method 'setBreakpoint' can't access dead object
>   writeError resource://devtools/shared/protocol/Actor.js:92
    handler resource://devtools/shared/protocol/Actor.js:215

InvisibleToDebugger: TypeError { }
>   writeError resource://devtools/shared/protocol/Actor.js:99
    handler resource://devtools/shared/protocol/Actor.js:215

Which more or less gives an indication to me that breakpoints aren't working with dark reader's specific code. But I'm currently just working around by using console.log and not a big deal for me.

I'd had a look and the Show Content Messages are on and have some kind of progress in figuring on what v91 broke/changed for darkreader, especially after lookin up some suggestion on that linked group. I'm going mark it as resolved as I'm somewhat able to get dark reader working again. Thank you!