1725890 - "Clear Recent History" should use verbs for primary action instead of "OK" (isn't using "Clear Now" string that it's supposed to)

Status: RESOLVED WORKSFORME

(Toolkit :: Data Sanitization, defect, P3)

Description

[Asif Youssuff]

Per macOS HIG:

Use verbs in push button titles. An action-specific title shows that the button is interactive and conveys what happens when clicked. For example, Save, Close, Print, Delete, and Change Password are action-specific titles. Because buttons initiate immediate actions, there’s no need for to include a time descriptor like Now.

I looked at https://hg.mozilla.org/mozilla-central/file/tip/browser/locales/en-US/browser/sanitize.ftl and it seems like "sanitize-button-ok" has the label "Clear Now", but it isn't being used by the new dialog in bug 1712750.

sanitizeDialog.js also seems to reference this string in

    let OKButton = this._dialog.getButton("accept");
    document.l10n.setAttributes(OKButton, "sanitize-button-ok");

so this seems like this is the bug, and the string in the code is by design.

Comment 1

[:Gijs (he/him)]

This is unrelated to the UI styling or proton design changes, as the exact same thing happened before those changes.

Comment 2

[:Gijs (he/him)]

Regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9af589864188fc4061a020c45914f54fa9f67b0d&tochange=011ad9ff26088e341b0aebecd4424523b7759e88

Comment 3

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #2)

Regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9af589864188fc4061a020c45914f54fa9f67b0d&tochange=011ad9ff26088e341b0aebecd4424523b7759e88

Zibi, do you know why this fluent change broke localization here?

Comment 4

[aoia7rz7l]

Looks like this was fixed in 112 by https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d709b8c58a4e35a71f99401f56e8e80db08f7a34&tochange=d24bb2cea16d4a9499b491ee5dbbd5e98a499a2d?

Comment 5

[:Gijs (he/him)]

Thanks for flagging, that sort of makes sense...