1725915 - All the saved logins are no longer sorted when selecting the “Username(A-Z)” and the “Username(Z-A)” options from the “Sort by:” drop-down

Status: VERIFIED FIXED

(Firefox :: about:logins, defect)

Description

[Simona Rosu [:srosu], Ecosystem QA, PTO until April 20 - NI to: [e-mail]]

Attachment: SortingLoginsByUsername.gif

[Affected versions]:

• Firefox Nightly 93.0a1 (Build ID: 20210815094823)

[Affected Platforms]:

• Mac 11.5.1
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the latest Firefox Nightly browser installed.
• Have a Firefox profile with multiple logins saved.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to the “about:logins” page.
3. Click on the “Sort by:” dropdown menu.
4. Select the “Username(A-Z)” or the “Username(Z-A)” option.
5. Observe the Login LIst.

[Expected result]:

• All the saved logins are correctly sorted.

[Actual result]:

• Nothing happens.

[Regression]

• The issue is not reproducible with older Nightly 93.0a1 builds. Considering this using mozregression tools I have found the regression range. Here are the results:
  Last good revision: d97a050c677e87913002d60f92d811a175e022d4
  First bad revision: 6bb6be51f4fa1ad7f5741e98cc0749c76f4126b3
  Pushlog: link

From this pushlog I think the patch for Bug 1592682 introduced this behavior.

[Notes]:

• Attached is a screen recording of the issue.

Comment 1

[Antonin LOUBIERE]

Attachment: Bug 1725915 - Fix sort usernames in login-list.js. r=jaws

Fix the sort of usernames in login-list.js.

Comment 2

[Eitan Isaacson [:eeejay]]

Removing access keyword since this seems like a more general bug.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71b213ebf74a
Fix sort usernames in login-list.js. r=tgiles

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c2f148f4207
Fix trailing whitespace error in test_login_list.html a=lint-fix

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/71b213ebf74a
https://hg.mozilla.org/mozilla-central/rev/4c2f148f4207

Comment 6

[Simona Rosu [:srosu], Ecosystem QA, PTO until April 20 - NI to: [e-mail]]

I have verified this issue using the latest Firefox Nightly 93.0a1 (Build ID: 20210817094606) on Windows 10 x64, Mac 11.5.1, Ubuntu 20.04 x64.

• All the saved logins are correctly sorted when selecting the “Username(A-Z)” and the “Username(Z-A)” options.