1725969 - The “Create New Login” mode is not dismissed after clicking the “Save” button if any of the “Username” sort is active

Status: VERIFIED FIXED

(Firefox :: about:logins, defect)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: SortingLoginsByUsername_CreateNewLogin.gif

[Affected versions]:

• Firefox Nightly 93.0a1 (Build ID: 20210815094823)

[Affected Platforms]:

• Mac 11.5.1
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the latest Firefox Nightly browser installed.
• Have a Firefox profile with multiple logins saved.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to the “about:logins” page.
3. Click on the “Sort by:” dropdown menu.
4. Select the “Username(A-Z)” or the “Username(Z-A)” option.
5. Create a new login and click on the “Save” button.
6. Observe what happens.

[Expected result]:

• The created login is successfully created and displayed on the Login List.

[Actual result]:

• Nothing happens.

[Regression]

• The issue is not reproducible with older Nightly 93.0a1 builds. Considering this using mozregression tools I have found the regression range. Here are the results:
  Last good revision: d97a050c677e87913002d60f92d811a175e022d4
  First bad revision: 6bb6be51f4fa1ad7f5741e98cc0749c76f4126b3
  Pushlog: link

From this pushlog I think the patch for Bug 1592682 introduced this behavior.

[Notes]:

• The login is correctly saved, but the “Create New Login” modal is not dismissed, only after refreshing the page.
• After clicking the second time on the “Save” button the newly created login is recognized as a duplicate.
• Attached is a screen recording of the issue.

Comment 1

[Simona Rosu [:srosu], Ecosystem QA]

After further investigation, I have noticed that a similar behavior can be observed after importing or syncing logins. The synced or imported logins are not displayed in Login List while the “Username” sort is active. They are displayed only after the page is refreshed.

Comment 2

[Antonin LOUBIERE]

Hi thanks for the report. I have fix the issue in D122708 which is attached to a similar regression report: bug 1725915.

The issue came from a missing piece of code that result in an error, in an important place, I think that this missing part affects a lot of functionality of the about:logins but the revision should fix them all.

Comment 3

[Simona Rosu [:srosu], Ecosystem QA]

• Yes indeed, this issue is fixed by the revision you have mentioned.
  I have verified this issue using the latest Firefox Nightly 93.0a1 (Build ID: 20210817094606) on Windows 10 x64, Mac 11.5.1, Ubuntu 20.04 x64.
• The “Create New Login” mode is dismissed after clicking the “Save” button if any of the “Username” sorts is active, and the newly created login is added to the Login List.
  Considering these I’m marking this issue as Resolved Fixed.