1726037 - browser_jsterm_autocomplete_race_on_enter.js has an unexpected comma operator

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Mark Banner (:standard8)]

I'm looking to update ESLint, and it is picking up an instance of a unexpected comma operator:

devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_race_on_enter.js
132:35 error Unexpected use of comma operator. no-sequences (eslint)

This was introduced by bug 1595068. The code in question is:

https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/devtools/client/webconsole/test/browser/browser_jsterm_autocomplete_race_on_enter.js#132

await Promise.all[(onPopupClosed, onMessage)];

The brackets are the wrong way around. If I try to fix it, then the test hangs. Nicolas would you be able to take a look?

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

sure, let me pick that up

(sorry for the late response, I'm just back from PTO)

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1726037 - [devtools] Fix browser_jsterm_autocomplete_race_on_enter . r=bomsy.

The test had a weird syntax which was preventing a Promise.all call
to be actually completed.
Fixing the syntax error showed a flaw in the test so it had to be
fixed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0581e2bb02c5
[devtools] Fix browser_jsterm_autocomplete_race_on_enter . r=bomsy.

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/0581e2bb02c5