1726070 - [wpt-sync] Sync PR 30045 - Revert "Store both a ScriptPromise and ScriptPromiseResolver on OngoingNavigation"

Status: RESOLVED INVALID

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 30045 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30045
Details from upstream follow.

b'Findit <[e-mail]>' wrote:

Revert "Store both a ScriptPromise and ScriptPromiseResolver on OngoingNavigation"

This reverts commit c6dc17d9e3c6b6f18a436316750a9e708a45571f.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 912293 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M2ZGMxN2Q5ZTNjNmI2ZjE4YTQzNjMxNjc1MGE5ZTcwOGE0NTU3MWYM

Sample Failed Build: https://ci.chromium.org/b/8838707798999048992

Sample Failed Step: compile

Original change's description:

Store both a ScriptPromise and ScriptPromiseResolver on OngoingNavigation

ScriptPromiseResolver assumes that its associated promise will be
returned, and resolving the promise will happen later. It is not designed
to resolve before the promise is returned, and clears its reference to
the promise on resolve. By immediately grabbing the promise from the
resolver, we can clean up several small messes where AppHistory had to
work around this limitation.

This also makes it possible to synchronously fire the navigaterror
event, per issue 1237515.

Finally, we can now reject appHistory.goTo() promises on frame detach.
This allows us to pass
external/wpt/app-history/navigate/goTo-detach-in-onnavigate.html,
which was timing out before.

Bug: 1237515, 1219750
Change-Id: I104a473f847d67c9251af18609bb8626ee594eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3089789
Commit-Queue: Nate Chapin \<[e-mail]>
Commit-Queue: Domenic Denicola \<[e-mail]>
Auto-Submit: Nate Chapin \<[e-mail]>
Reviewed-by: Domenic Denicola \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#912293}

Change-Id: I542852e2a7809858568a8d40707a25da60d9c4ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1237515, 1219750

Reviewed-on: https://chromium-review.googlesource.com/3098909
WPT-Export-Revision: d040ae4a1433da29486205c3de10a57855967b26

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 30045 applied with additional changes from upstream: 555bb7578867a4a00bd3116bd775aead46e7f705