Closed Bug 1726097 Opened 4 months ago Closed 3 months ago

[wpt-sync] Sync PR 30048 - Do not crash when serializing inverted zero via CSSTransformValue

Categories

(Core :: DOM: CSS Object Model, task, P4)

task

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30048 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30048
Details from upstream follow.

b'Anders Hartvoll Ruud <andruud@chromium.org>' wrote:

Do not crash when serializing inverted zero via CSSTransformValue

There seems to be plenty of opportunities for CSSStyleValue::ToCSSValue
to return nullptr, so the DCHECK seems wrong.

I'm not testing in WPT that the return value is "", since it's not
actually supposed to be "". But the full fix for that should probably
be done separately. Filed crbug.com/1240306 for this.

Fixed: 1232775
Bug: 1240306
Change-Id: I1d087cdbefb8d48bddf4b06de495934006975614
Reviewed-on: https://chromium-review.googlesource.com/3097607
WPT-Export-Revision: abd8c449626926d34c1d7befb0ee02fa6d21b23b

Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/001ac3867eef
[wpt PR 30048] - Do not crash when serializing inverted zero via CSSTransformValue, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.