Closed Bug 1726170 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 30051 - [selectmenu] Add basic keyboard support

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30051 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30051
Details from upstream follow.

b'Dan Clark <daniec@microsoft.com>' wrote:

[selectmenu] Add basic keyboard support

Apply "controller" code to \<selectmenu> parts for the following
behaviors:

  • Enter key opens and closes the listbox.
  • Spacebar opens the listbox (but does not close it -- this is
    suspicious but consistent with Chromium \<select>. Firefox's Enter and
    Spacebar behavior for \<select> is a bit different; we may want to
    evaluate this in OpenUI).
  • Up/Down Arrow move up/down through the list of options.

Event propagation is suppressed to prevent the default browser
behavior of scrolling the window on arrow keys or spacebar.

Bug: 1121840
Change-Id: I94c994ed8b381ef075683df807e852e9c92427ce

Reviewed-on: https://chromium-review.googlesource.com/3098769
WPT-Export-Revision: c31b631ab7c0119243118d5ed676025de4bc8d3c

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/forms/the-selectmenu-element/selectmenu-keyboard.tentative.html
Validate Enter, Up/Down Arrow, and Space keyboard accessibility support for <selecmenu>: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2c29abe21fda [wpt PR 30051] - [selectmenu] Add basic keyboard support, a=testonly https://hg.mozilla.org/integration/autoland/rev/268b6313a5ee [wpt PR 30051] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2c29abe21fda
https://hg.mozilla.org/mozilla-central/rev/268b6313a5ee

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.