1726171 - We still have --lwt-toolbar-field-background-color variables in the tree

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Bug 1715128 should have changed all --lwt-toolbar-field-background-color variables but missed some.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1726171-fix-variable.patch

Fix em.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9236650 [details] [diff] [review]
1726171-fix-variable.patch

Review of attachment 9236650 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for this clean up, but I'm not sure I like how now the addressing fields in the compose window have that faint blue tint in dark mode.
It doesn't work well with our desaturated dark mode.
I know we inherit some of those color accents from FF, which affect our menu popups, but in the future we should get rid of those as well.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9236650 [details] [diff] [review]
1726171-fix-variable.patch

Review of attachment 9236650 [details] [diff] [review]:
-----------------------------------------------------------------

Updating my review after discussing it on Matrix as the blue tint dark color is part of 91.
We will deal with finding a better color in a follow up bug.

Let's update the commit message with "Remove the --lwt-toolbar-field-background-color variable leftovers."

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1726171-fix-variable.patch

Updated the commit message.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fe95a968408e
Remove the --lwt-toolbar-field-background-color variable leftovers. r=aleca

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9236691 [details] [diff] [review]
1726171-fix-variable.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1715128
User impact if declined: not the correct textfield background colour on some fields
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9236691 [details] [diff] [review]
1726171-fix-variable.patch

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 92.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/f419b9a0e163