Closed Bug 1726175 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30052 - Migrate cookie-test.js to async_test

Categories

(Core :: Networking: Cookies, task, P4)

Product:
Core
Component:
Networking: Cookies
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30052 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30052
Details from upstream follow.

b'Ari Chivukula <arichiv@chromium.org>' wrote:

Migrate cookie-test.js to async_test

A stacked CL will require these all use async_test to permit awaitables
in the test and in cleanup functions. I seek to anticipate that need
here in order to divide the 'no-op' portion of the stacked change from
the substantive part.

Bug: 1233305
Change-Id: Iab8ea9a5b20eec28f47fd66f423ff75bbb3ef9de
Reviewed-on: https://chromium-review.googlesource.com/3099515
WPT-Export-Revision: 4d1a477a977ce1112d8afbfb646404a11a25a550

Component: web-platform-tests → Networking: Cookies
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 15 tests and 23 subtests

Status Summary

Firefox

OK : 15
PASS: 372
FAIL: 100

Chrome

OK : 15
PASS: 466
FAIL: 6

Safari

OK : 15
PASS: 252
FAIL: 220

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/cookies/attributes/path-redirect.html
No cookie sent for redirected path mismatch with trailing '?' after unquoted Path: FAIL
No cookie sent for redirected path mismatch with trailing '#' after unquoted Path: FAIL
/cookies/name/name-ctl.html
Cookie with %x7f in name is rejected.: FAIL
/cookies/name/name.html
Use last value for cookies with identical names: FAIL
Keep first-in, first-out name order: FAIL
Keep first-in, first-out single-char name order: FAIL

New Tests That Don't Pass

/cookies/attributes/domain.sub.html
No cookie returned for domain mismatch (with domain mismatch as first domain attribute and second a bare attribute): FAIL (Chrome: PASS, Safari: FAIL)
/cookies/attributes/invalid.html
Ignore Set-Cookie: = with other Set-Cookie headers: FAIL (Chrome: PASS, Safari: FAIL)
Ignore name- and value-less Set-Cookie: ; bar: FAIL (Chrome: PASS, Safari: FAIL)
/cookies/attributes/path-redirect.html
No cookie sent for redirected path mismatch with trailing '?' after unquoted Path: FAIL (Chrome: PASS, Safari: PASS)
No cookie sent for redirected path mismatch with trailing '#' after unquoted Path: FAIL (Chrome: PASS, Safari: PASS)
/cookies/name/name-ctl.html
Cookie with %x7f in name is rejected.: FAIL (Chrome: PASS, Safari: PASS)
/cookies/name/name.html
Return the most recent nameless cookie, even if preceded by =, in addition to other valid cookie: FAIL (Chrome: PASS, Safari: FAIL)
Use last value for cookies with identical names: FAIL (Chrome: PASS, Safari: PASS)
Keep first-in, first-out name order: FAIL (Chrome: PASS, Safari: PASS)
Keep first-in, first-out single-char name order: FAIL (Chrome: PASS, Safari: PASS)
Keep non-alphabetic first-in, first-out name order: FAIL (Chrome: PASS, Safari: FAIL)
Keep first-in, first-out order if comma-separated: FAIL (Chrome: PASS, Safari: FAIL)
Set nameless cookie, given Set-Cookie: =test16: FAIL (Chrome: PASS, Safari: FAIL)
Overwrite nameless cookie: FAIL (Chrome: PASS, Safari: FAIL)
Ignore cookie with empty name and empty value: FAIL (Chrome: PASS, Safari: FAIL)
Ignore cookie with no name or value: FAIL (Chrome: PASS, Safari: FAIL)
URL-encoded cookie name is not decoded: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for a=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for 1=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for $=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for !a=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for @a=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for #a=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for $a=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for %a=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for ^a=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for &a=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for *a=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for (a=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for )a=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for -a=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for _a=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for +=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for "a=test: FAIL (Chrome: PASS, Safari: FAIL)
Name is set as expected for "a=b"=test: FAIL (Chrome: PASS, Safari: FAIL)
/cookies/size/attributes.www.sub.html
Too long path attribute (>1024 bytes) is ignored; previous valid path wins.: FAIL (Chrome: FAIL, Safari: FAIL)
Too long domain attribute (>1024 bytes) is ignored; previous valid domain wins.: FAIL (Chrome: FAIL, Safari: FAIL)
/cookies/size/name-and-value.html
Set max-size cookie with largest possible name and value (4096 bytes): FAIL (Chrome: FAIL, Safari: FAIL)
Ignore cookie with name larger than 4096 and 1 byte value: FAIL (Chrome: PASS, Safari: FAIL)
Set max-size value-less cookie: FAIL (Chrome: FAIL, Safari: FAIL)
Ignore value-less cookie with name larger than 4096 bytes: FAIL (Chrome: PASS, Safari: FAIL)
Set max-size cookie with largest possible value (4095 bytes): FAIL (Chrome: FAIL, Safari: FAIL)
Ignore named cookie (with non-zero length) and value larger than 4095 bytes: FAIL (Chrome: PASS, Safari: FAIL)
Ignore named cookie with length larger than 4095 bytes, and a non-zero value: FAIL (Chrome: PASS, Safari: FAIL)
Set max-size name-less cookie: FAIL (Chrome: FAIL, Safari: FAIL)
Ignore name-less cookie with value larger than 4096 bytes: FAIL (Chrome: PASS, Safari: FAIL)
Ignore name-less cookie (without leading =) with value larger than 4096 bytes: FAIL (Chrome: PASS, Safari: FAIL)
/cookies/value/value-ctl.html
Cookie with %x1 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x2 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x3 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x4 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x5 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x6 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x7 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x8 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x9 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %xb in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %xc in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %xe in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %xf in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x10 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x11 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x12 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x13 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x14 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x15 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x16 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x17 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x18 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x19 in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x1a in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x1b in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x1c in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x1d in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x1e in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x1f in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
Cookie with %x7f in value is rejected.: FAIL (Chrome: PASS, Safari: FAIL)
/cookies/value/value.html
Set value containing a comma: FAIL (Chrome: PASS, Safari: FAIL)
Set quoted value containing a comma: FAIL (Chrome: PASS, Safari: FAIL)
Ignore values after semicolon: FAIL (Chrome: PASS, Safari: FAIL)
Ingore whitespace at the end of value: FAIL (Chrome: PASS, Safari: FAIL)
Set value including quotes and whitespace up until semicolon: FAIL (Chrome: PASS, Safari: FAIL)
Set value with a single quote excluding whitespace: FAIL (Chrome: PASS, Safari: FAIL)
Set nameless cookie to its value: FAIL (Chrome: PASS, Safari: FAIL)
Set nameless cookie to its value with an escaped quote: FAIL (Chrome: PASS, Safari: FAIL)
Set value with unbalanced leading quote: FAIL (Chrome: PASS, Safari: FAIL)
Set nameless cookie followed by '=' to its value: FAIL (Chrome: PASS, Safari: FAIL)
Set cookie with large value ( = 4kb): FAIL (Chrome: PASS, Safari: FAIL)
Ignore cookie with large value ( > 4kb): FAIL (Chrome: PASS, Safari: FAIL)
Set cookie but ignore value after LF: FAIL (Chrome: PASS, Safari: FAIL)
Set cookie ignoring whitespace after value endquote: FAIL (Chrome: PASS, Safari: FAIL)
Ignore whitespace and ; after value: FAIL (Chrome: PASS, Safari: FAIL)
Ignore whitespace preceding value: FAIL (Chrome: PASS, Safari: FAIL)
Set cookie with quotes in value: FAIL (Chrome: PASS, Safari: FAIL)
Set cookie keeping whitespace inside quoted value: FAIL (Chrome: PASS, Safari: FAIL)
Set cookie value ignoring characters after semicolon: FAIL (Chrome: PASS, Safari: FAIL)
Set cookie with another = inside quoted value: FAIL (Chrome: PASS, Safari: FAIL)
Set cookie ignoring whitespace surrounding value and characters after first semicolon: FAIL (Chrome: PASS, Safari: FAIL)
Set valueless cookie, given Set-Cookie: test22=: FAIL (Chrome: PASS, Safari: FAIL)
URL-encoded cookie value is not decoded: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f2d24203f151
[wpt PR 30052] - Migrate cookie-test.js to async/await based promise_test, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f2d24203f151

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.