1726205 - [wpt-sync] Sync PR 30055 - Add shared locks for writable streams

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 30055 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30055
Details from upstream follow.

b'Emanuel Krivoy <[e-mail]>' wrote:

Add shared locks for writable streams

This CL implements the missing methods in WriteLockManager and hooks
them up to the file writer lifecycle. This enables shared write locks
when creating writable streams.

When a shared lock is taken by creating a writable stream, the creation
of access handles on the same file is prevented. Creating new writables
is permitted. Closing all writables releases the lock on the file.

Bug: 1218431
Change-Id: I9c21b901ed0f5f331682c8a6b75db5e28674e5a3
Reviewed-on: https://chromium-review.googlesource.com/3100189
WPT-Export-Revision: 1b982f4133ca01dce77eaed7bf7f41637fab7f57

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d461786517653f30a820b9a82ef6ff1364b38672

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
FAIL: 6

Chrome

OK : 1
FAIL: 6

Safari

OK : 1
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/file-system-access/sandboxed_FileSystemFileHandle-sync-access-handle-writable-lock.https.tentative.worker.html
There can only be one open access handle at any given time: FAIL (Chrome: FAIL, Safari: FAIL)
An access handle from one file does not interfere with the creation of an access handle on another file: FAIL (Chrome: FAIL, Safari: FAIL)
A writable stream from one file does not interfere with the creation of an access handle on another file: FAIL (Chrome: FAIL, Safari: FAIL)
An access handle from one file does not interfere with the creation of a writable stream on another file: FAIL (Chrome: FAIL, Safari: FAIL)
Writable streams cannot be created if there is an open access handle: FAIL (Chrome: FAIL, Safari: FAIL)
Access handles cannot be created if there are open Writable streams: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9a5eedb6f82
[wpt PR 30055] - Switch to refcounted locks, add shared locks for writable streams, a=testonly
https://hg.mozilla.org/integration/autoland/rev/86ebec1d0e47
[wpt PR 30055] - Update wpt metadata, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e9a5eedb6f82
https://hg.mozilla.org/mozilla-central/rev/86ebec1d0e47