Closed Bug 1726231 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 30060 - App history: rename respondWith() to transitionWhile()

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox93 fixed)

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 30060 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/30060
Details from upstream follow.

b'Domenic Denicola <domenic@chromium.org>' wrote:

App history: rename respondWith() to transitionWhile()

... and canRespond to canTransition.

Follows https://github.com/WICG/app-history/pull/151.

Bug: 1183545
Change-Id: Ide039a88cb9a40688a0fff99ff8b3a954a12faaa
Reviewed-on: https://chromium-review.googlesource.com/3100807
WPT-Export-Revision: 4cf2a1118b3b49b93f7ca72802b5e97accb86f8a

PR 30060 applied with additional changes from upstream: 555bb7578867a4a00bd3116bd775aead46e7f705, c0c7793b9417c2fd00149b30acdefa902039e8a7

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 49 tests and 1 subtests

Status Summary

Firefox

OK : 48
FAIL : 52
ERROR : 1

Chrome

OK : 37
PASS : 5
FAIL : 40
TIMEOUT: 1
ERROR : 12

Safari

OK : 48
FAIL : 52
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/app-history/navigate/navigate-transitionWhile-history-state.html
history.story should be nulled by navigate() handled by transitionWhile(): FAIL (Chrome: PASS, Safari: FAIL)
/app-history/navigate/navigate-transitionWhile-reject-event-order.html
navigate() event ordering for same-document navigation: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/app-history/navigate/navigate-transitionWhile-reject.html: ERROR (Chrome: ERROR, Safari: ERROR)
navigate() and transitionWhile() with a rejected promise: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate/navigate-transitionWhile.html
navigate() and transitionWhile() with a fulfilled promise: FAIL (Chrome: PASS, Safari: FAIL)
/app-history/navigate/reload-service-worker-fetch-event.html
reload() appears as a reload to service worker fetch event handlers: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate/reload-state-and-info.html
reload() variant with info and new state: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate/reload-state-undefined.html
reload() variant with info and state: undefined counts the same as not present (because of Web IDL dictionary semantics), so preserves the state: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/event-constructor.html
destination is required: FAIL (Chrome: PASS, Safari: FAIL)
signal is required: FAIL (Chrome: PASS, Safari: FAIL)
all properties are reflected back: FAIL (Chrome: FAIL, Safari: FAIL)
defaults are as expected: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-anchor-cross-origin.html
<a> cross-origin navigate event: FAIL (Safari: FAIL)
/app-history/navigate-event/navigate-anchor-fragment.html
Fragment <a> click fires navigate event: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-anchor-same-origin-cross-document.html
<a> cross-document (but same-origin) navigate event: FAIL (Safari: FAIL)
/app-history/navigate-event/navigate-anchor-userInitiated.html
Fragment <a> click fires navigate event: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-anchor-with-target.html
<a> with a target fires navigate event in target window but not source: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-appHistory-back-cross-document.html
navigate event for appHistory.back() - cross-document: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-appHistory-back-same-document.html
navigate event for appHistory.back() - same-document: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-appHistory-navigate.html
navigate event for appHistory.navigate(): FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-cross-origin-iframe-location.html
location API on another window fires navigate event even if the target window is cross-origin: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-form-get.html
<form> submission with GET method fires navigate event but with formData null: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-form-userInitiated.html
<form> submission fires navigate event: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-form-with-target.html
<form> submission with a target fires navigate event in target window but not source: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-form.html
<form> submission fires navigate event: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-history-back-after-fragment.html
history.back() fires the navigate event and sets hashChange when reversing a fragment navigation: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-history-back-after-pushState.html
history.back() fires the navigate event when reversing a pushState(): FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-history-go-0.html
history.go(0) fires the navigate event: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-history-pushState.html
history.pushState() fires the navigate event: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-history-replaceState.html
history.replaceState() fires the navigate event: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-iframe-location.html
location API on another window fires navigate event in the target window only: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-location.html
location API fires navigate event: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-meta-refresh.html
<meta> refresh fires navigate event: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-window-open-self.html
window.open() fires navigate event when targeting self: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigate-window-open.html
window.open() fires navigate event in target window but not source: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigateerror-ordering-location-api-reentrant.html
navigateerror ordering when navigating via the location API reentrantly: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigateerror-ordering-location-api.html
navigateerror ordering when navigating via the location API: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigateerror-ordering-transitionWhile-reentrant.html
navigateerror ordering when navigate() is called reentrantly and handled by transitionWhile(): FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/navigateerror-ordering-transitionWhile.html
navigateerror ordering when navigate() is called repeatedly and handled by transitionWhile(): FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/signal-abort-transitionWhile.html
AppHistoryNavigateEvent's transitionWhile() does not signal AppHistoryNavigateEvent's signal: FAIL (Safari: FAIL)
/app-history/navigate-event/signal-abort-window-stop-after-transitionWhile.html
window.stop() cancels AppHistoryNavigateEvent's transitionWhile() and signals AppHistoryNavigateEvent's signal: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/transitionWhile-appHistory-back.html
AppHistoryNavigateEvent's transitionWhile() can intercept appHistory.back(): FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/transitionWhile-cross-document-same-origin.html
AppHistoryNavigateEvent's transitionWhile() intercepts a same-origin cross-document navigation: FAIL (Safari: FAIL)
/app-history/navigate-event/transitionWhile-cross-origin.html
AppHistoryNavigateEvent's transitionWhile() should throw if called for a cross origin navigation: FAIL (Safari: FAIL)
/app-history/navigate-event/transitionWhile-detach.html
transitionWhile-detach: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/transitionWhile-history-pushState.html
AppHistoryNavigateEvent's transitionWhile() should proceed if the given promise resolves: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/transitionWhile-history-replaceState.html
AppHistoryNavigateEvent's transitionWhile() should proceed if the given promise resolves: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/transitionWhile-multiple-times-reject.html
AppHistoryNavigateEvent's transitionWhile() is called multiple times and one of the promises rejects: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/transitionWhile-multiple-times.html
appHistory.navigate() returns a promise that awaits all promises if AppHistoryNavigateEvent's transitionWhile() is called multiple times: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/transitionWhile-on-synthetic-event.html
AppHistoryNavigateEvent's transitionWhile() throws if invoked on a synthetic event: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/transitionWhile-reject.html
AppHistoryNavigateEvent's transitionWhile() should abort if the given promise rejects: FAIL (Chrome: FAIL, Safari: FAIL)
/app-history/navigate-event/transitionWhile-resolve.html
AppHistoryNavigateEvent's transitionWhile() should proceed if the given promise resolves: FAIL (Chrome: PASS, Safari: FAIL)
/app-history/navigate-event/transitionWhile-same-document-history-back.html
AppHistoryNavigateEvent's transitionWhile() can intercept same-document history.back(): FAIL (Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8065df6b369b
[wpt PR 30060] - App history: rename respondWith() to transitionWhile(), a=testonly
https://hg.mozilla.org/integration/autoland/rev/36096103b860
[wpt PR 30060] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8065df6b369b
https://hg.mozilla.org/mozilla-central/rev/36096103b860

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.